From 688d84400d2b9fa3dae4b7aa020cb924d4c487fe Mon Sep 17 00:00:00 2001
From: Alex Goodman <wagoodman@users.noreply.github.com>
Date: Thu, 6 Jun 2024 10:33:51 -0400
Subject: [PATCH] simplify the compare_semver install function

Co-authored-by: Dominique Martinet <asmadeus@codewreck.org>
---
 install.sh | 35 +++++------------------------------
 1 file changed, 5 insertions(+), 30 deletions(-)

diff --git a/install.sh b/install.sh
index 962029cba03e..c7c0d6b2685c 100755
--- a/install.sh
+++ b/install.sh
@@ -693,36 +693,11 @@ install_asset() (
 # Note: pre-release (-) and metadata (+) are not supported.
 compare_semver() {
     # remove leading 'v' if present
-    version1=$(echo "$1" | sed 's/^v//')
-    version2=$(echo "$2" | sed 's/^v//')
-
-    IFS=. read -r major1 minor1 patch1 <<EOF
-$version1
-EOF
-    IFS=. read -r major2 minor2 patch2 <<EOF
-$version2
-EOF
-
-    if [ "$major1" -gt "$major2" ]; then
-        return 0
-    elif [ "$major1" -lt "$major2" ]; then
-        return 1
-    fi
-
-    if [ "$minor1" -gt "$minor2" ]; then
-        return 0
-    elif [ "$minor1" -lt "$minor2" ]; then
-        return 1
-    fi
-
-    if [ "$patch1" -gt "$patch2" ]; then
-        return 0
-    elif [ "$patch1" -lt "$patch2" ]; then
-        return 1
-    fi
-
-    # versions are equal
-    return 0
+    local version1=${1#v}
+    local version2=${2#v}
+    
+    # this checks $2 <= $1, so returns 0 if first argument <= second
+    printf "%s\n" "$version2" "$version1" | sort -Vc 2>/dev/null
 }
 
 prep_signature_verification() {