Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support creation of service accounts and default assignment #236

Open
brandtkeller opened this issue Jan 9, 2023 · 1 comment
Open

Support creation of service accounts and default assignment #236

brandtkeller opened this issue Jan 9, 2023 · 1 comment

Comments

@brandtkeller
Copy link
Contributor

Looking over the chart - I see the ability to assign a serviceAccount to pods based on the 'serviceAccountName` of each service.

What I would like to see is a default serviceAccount resource be available for creation - Example - and the assignment of that serviceAccount to the services that do not have serviceAccountName declared.

Summary:

  • ServiceAccount.enabled defaulted to false and no serviceAccountName entries = same default state as is currently.
  • ServiceAccount.enabled defaulted to true and no serviceAccountName entries = baseline service account for all services.
  • ServiceAccount.enabled defaulted to true and a serviceAccountName entry on an individual service = baseline service account on all services except that individual service.

I believe this further encapsulates possible resources that should be created with the chart and those that could be integrated by overrides.

I'll do some testing around this concept and leave some more thoughts as I go - just wanted to get it written down such that others could review, and possibly indicate that not having the ability to create a baseline serviceAccount was explicitly by design.

@brandtkeller
Copy link
Contributor Author

I did see mention in the changelog about the removal of a createServiceAccount from anchoreCatalog values. I believe this is different - because it would be more of a boolean enabled: <true/false> for a default service account.

@Btodhunter I'm open to any thoughts about why this may be something that the chart may not explicitly want to own.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant