diff --git a/.github/workflows/pull-request-checker.yml b/.github/workflows/pull-request-checker.yml index 63a506b365..c91792e1b7 100644 --- a/.github/workflows/pull-request-checker.yml +++ b/.github/workflows/pull-request-checker.yml @@ -13,7 +13,7 @@ jobs: initial-comment: name: PR Instructions runs-on: ubuntu-latest - # if: github.event.action == 'opened' + if: github.event.action == 'opened' && github.actor != 'zowe-robot' steps: - name: Add initial comment w/ instructions @@ -27,11 +27,12 @@ jobs: - [ ] Add the label `needs review by sme` if an SME needs to check your content. - [ ] Identify your content topic with a label. (Examples: `area: apiml`, `area: cli`, `area: install and config`, etc.) - - [ ] Specify the Zowe release for your content. Use either label `current release` or `next release`. + - [ ] Specify the major Zowe release for your content. (Examples: `V1`, `V2`, `V3`.) - [ ] Link any [Doc Issues](https://github.com/zowe/docs-site/issues) related to this PR. - [ ] Fix broken links found in your content areas. - [ ] Notify the SME to review this PR (if applicable). - - [ ] Merge to the `master` branch if your content documents the current release or a previous release. Merge to `docs-staging` if your content is for the next release. + - [ ] Merge to the `master` branch if your PR updates content that is on the live site. Merge to `docs-staging` if your PR updates content for a future release. + - name: Add initial comment w/ instructions if: steps.initial_comment_writer.outcome == 'skipped' @@ -43,8 +44,8 @@ jobs: - [ ] Add the label `needs review by doc`. - [ ] Identify your content topic with a label. (Examples: `area: apiml`, `area: cli`, `area: install and config`, etc.) - - [ ] Specify the Zowe release for your content. Use either label `current release` or `next release`. - - [ ] Select the `master` branch if your content documents the current release or a previous release. Select `docs-staging` if your content is for the next release. + - [ ] Specify the major Zowe release for your content. (Examples: `V1`, `V2`, `V3`.) + - [ ] Select the `master` branch if your PR updates content that is on the live site. Select `docs-staging` if your PR updates content for a future release. - [ ] Notify the Doc Squad about this PR. If you don't know who should review your content, message the [#zowe-doc](https://openmainframeproject.slack.com/archives/CC961JYMQ) Slack channel. If you know which Doc Squad writer should approve your content, add that person as a reviewer. **Need help?** Contact the Doc Squad in the [#zowe-doc](https://openmainframeproject.slack.com/archives/CC961JYMQ) Slack channel. @@ -76,8 +77,9 @@ jobs: review-labels: name: Check for missing review label - if: ${{ !contains(fromJson('["anaxceron", "jandacek", "nannanli", "samanthasusu", "nellietan", "lparadkar-rocket"]'), github.event.pull_request.user.login) }} runs-on: ubuntu-latest + needs: [initial-comment] + if: ${{ always() && (needs.initial-comment.result == 'success' || needs.initial-comment.result == 'skipped') && github.actor != 'zowe-robot' && !contains(fromJson('["anaxceron", "jandacek", "nannanli", "samanthasusu", "nellietan", "lparadkar-rocket"]'), github.event.pull_request.user.login) }} steps: - name: Review Label Check @@ -99,6 +101,8 @@ jobs: release-labels: name: Check for missing release label runs-on: ubuntu-latest + needs: [initial-comment] + if: ${{ always() && (needs.initial-comment.result == 'success' || needs.initial-comment.result == 'skipped') && github.actor != 'zowe-robot' }} steps: - id: prefix_label_check @@ -118,6 +122,8 @@ jobs: area-labels: name: Check for missing area label runs-on: ubuntu-latest + needs: [initial-comment] + if: ${{ always() && (needs.initial-comment.result == 'success' || needs.initial-comment.result == 'skipped') && github.actor != 'zowe-robot' }} steps: - id: prefix_label_check