Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependency version information to a central file #89

Open
eureka-cpu opened this issue Nov 1, 2024 · 0 comments · May be fixed by #105
Open

Add dependency version information to a central file #89

eureka-cpu opened this issue Nov 1, 2024 · 0 comments · May be fixed by #105
Assignees

Comments

@eureka-cpu
Copy link
Contributor

eureka-cpu commented Nov 1, 2024

The project depends on quite a lot of dependencies to be present, it would be nice to just have them declared somewhere similarly to the rust-toolchain.toml

I'd prefer it if it were a toml file, and to be frank having another toolchain file sort of feels like bloat. IMO we could just use the rust-toolchain.toml to add extra tables to represent the dependencies we don't already manage via the root Cargo.toml (if any). Otherwise I'd be fine with just writing a function for the nix side of things to get the versions from there. The rust-toolchain.toml only looks for certain tables and fields so adding explicit ones won't affect anything else. Something like:

# rust-toolchain.toml
[toolchain]
channel = "X.X.X"
components = ["rustfmt", "clippy", "rust-analyzer"]

[toolchain.flatc]
version = "24.3.25"
hash = "sha256-uE9CQnhzVgOweYLhWPn2hvzXHyBbFiFVESJ1AEM3BmA="

[toolchain.risc0-groth16-prover]
version = "v2024-05-17.1"
hash = "sha256-SV8nUjtq6TheYW+vQltyApOa7/gxnBrWx4Y6fQ71LFg="

# etc

Open to suggestions.
Ref #29

@eureka-cpu eureka-cpu changed the title Add dependency version information to a central file for use in containers Add dependency version information to a central file Nov 25, 2024
@eureka-cpu eureka-cpu self-assigned this Dec 8, 2024
@eureka-cpu eureka-cpu linked a pull request Dec 8, 2024 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant