Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated pkg_resources with packaging #726

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

mattkram
Copy link
Collaborator

@mattkram mattkram commented Oct 1, 2024

Replaces the usage of the deprecated pkg_resources library with packaging instead.

There were two usages:

  1. I've removed the version comparison, as it is not currently being used for anything. We could have used the Version class in the packaging library, but this whole warning is unnecessary.
  2. Replaced the custom parsing of pypi-style requirements with packaging.requirements.Requirement. This simplifies the usage significantly and removes the DeprecationWarning that was being raised.

I've also updated the pytest settings to treat warnings as errors to allow addressing deprecation warnings earlier in the future.

Resolves: #713

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant