Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

laravel 5.2 incompatability #27

Open
ITwrx opened this issue Dec 23, 2015 · 6 comments
Open

laravel 5.2 incompatability #27

ITwrx opened this issue Dec 23, 2015 · 6 comments

Comments

@ITwrx
Copy link
Contributor

ITwrx commented Dec 23, 2015

Not to rush you on updating for laravel 5.2 but i thought i'd post this for your reference.

FatalErrorException in LaravelShopProvider.php line 91: Call to undefined method Illuminate\Foundation\Application::bindShared()

Thanks

@ujwaldhakal
Copy link

change bindShared to singleton in laravel-shop/src/LaravelShopProvider/

@ITwrx
Copy link
Contributor Author

ITwrx commented Jan 5, 2016

Thanks for your help. i did do that after i posted this but there seemed to be further changes needed with laravel-shop elsewhere so i pulled off temporarily. are you successfully using laravel-shop with 5.2?

@ujwaldhakal
Copy link

no not in 5.2 are there more issues let me know?

@ITwrx
Copy link
Contributor Author

ITwrx commented Jan 5, 2016

added new issue #31

thanks

@DigitalCoder
Copy link

Laravel 5.2
/vendor/amsgames/laravel-shop/src/LaravelShopProvider.php

change this
/*$this->app->bindShared('command.laravel-shop.migration', function ($app) { return new MigrationCommand(); });*/
with
$this->app->singleton('command.laravel-shop.migration', function ($app) { return new MigrationCommand(); });

@ujwaldhakal
Copy link

This ain't gonna close better don't comment i am getting notification

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants