Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove vendor dir #549

Open
twifkak opened this issue Jul 15, 2021 · 0 comments
Open

Remove vendor dir #549

twifkak opened this issue Jul 15, 2021 · 0 comments

Comments

@twifkak
Copy link
Member

twifkak commented Jul 15, 2021

To do so, we need to address the use cases it serves:

  1. It makes it obvious when we're increasing our binary size too much. We could do this with a GH PR check that adds a comment to the PR "binary size is now $X".
  2. It's easy-ish to scan our new dependencies and make sure they have OSS-compatible licenses. Likewise, a bot could call go mod vendor and do some automated license checks, or at least print out a table with a link to the license for each dep (ideally highlighting new/changed deps).
  3. It (ideally) confirms that the dependency versions in prod are the same as those tested by our CI. This is handled by go.{mod,sum}; nothing to do.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant