From 4453242aefc0a9e88172a1ac06371c66d0d666e6 Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Tue, 15 Oct 2024 16:25:13 +0000 Subject: [PATCH 01/12] =?UTF-8?q?=F0=9F=93=A6=20Update=20subpackage=20devD?= =?UTF-8?q?ependencies=20(#40179)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> --- .github/workflows/codeql.yml | 6 +++--- .github/workflows/cross-platform-builds.yml | 4 ++-- .github/workflows/cut-nightly.yml | 4 ++-- .github/workflows/dependency-review.yml | 2 +- .github/workflows/release-tagger.yml | 4 ++-- .github/workflows/scorecard.yml | 6 +++--- .github/workflows/status-page.yml | 4 ++-- .github/workflows/update-session-issues.yml | 2 +- third_party/amp-toolbox-cache-url/package.json | 2 +- 9 files changed, 17 insertions(+), 17 deletions(-) diff --git a/.github/workflows/codeql.yml b/.github/workflows/codeql.yml index 0e9263d57e71..c3d58376efe0 100644 --- a/.github/workflows/codeql.yml +++ b/.github/workflows/codeql.yml @@ -34,16 +34,16 @@ jobs: egress-policy: audit # TODO: change to 'egress-policy: block' after couple of runs - name: Checkout repository - uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938 # v4.2.0 + uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 # v4.2.1 # Initializes the CodeQL tools for scanning. - name: Initialize CodeQL - uses: github/codeql-action/init@6db8d6351fd0be61f9ed8ebd12ccd35dcec51fea # v3.26.11 + uses: github/codeql-action/init@c36620d31ac7c881962c3d9dd939c40ec9434f2b # v3.26.12 with: config-file: ./.github/codeql/config.yml languages: ${{ matrix.language }} - name: Perform CodeQL Analysis - uses: github/codeql-action/analyze@6db8d6351fd0be61f9ed8ebd12ccd35dcec51fea # v3.26.11 + uses: github/codeql-action/analyze@c36620d31ac7c881962c3d9dd939c40ec9434f2b # v3.26.12 with: category: '/language:${{matrix.language}}' diff --git a/.github/workflows/cross-platform-builds.yml b/.github/workflows/cross-platform-builds.yml index 96303b6baef0..75e9836b916a 100644 --- a/.github/workflows/cross-platform-builds.yml +++ b/.github/workflows/cross-platform-builds.yml @@ -24,7 +24,7 @@ jobs: egress-policy: audit # TODO: change to 'egress-policy: block' after couple of runs - name: Checkout Repo - uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938 # v4.2.0 + uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 # v4.2.1 - name: Set Up Node uses: actions/setup-node@0a44ba7841725637a19e28fa30b79a866c81b0a6 # v4.0.4 with: @@ -48,7 +48,7 @@ jobs: with: egress-policy: audit # TODO: change to 'egress-policy: block' after couple of runs - - uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938 # v4.2.0 + - uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 # v4.2.1 - name: Create issue on error uses: JasonEtco/create-an-issue@1b14a70e4d8dc185e5cc76d3bec9eab20257b2c5 # v2.9.2 diff --git a/.github/workflows/cut-nightly.yml b/.github/workflows/cut-nightly.yml index 5097f4a8127c..f053b0cc0f40 100644 --- a/.github/workflows/cut-nightly.yml +++ b/.github/workflows/cut-nightly.yml @@ -25,7 +25,7 @@ jobs: egress-policy: audit # TODO: change to 'egress-policy: block' after couple of runs - name: Checkout Repo - uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938 # v4.2.0 + uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 # v4.2.1 with: fetch-depth: 100 @@ -59,7 +59,7 @@ jobs: with: egress-policy: audit # TODO: change to 'egress-policy: block' after couple of runs - - uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938 # v4.2.0 + - uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 # v4.2.1 - name: Create issue on error uses: JasonEtco/create-an-issue@1b14a70e4d8dc185e5cc76d3bec9eab20257b2c5 # v2.9.2 diff --git a/.github/workflows/dependency-review.yml b/.github/workflows/dependency-review.yml index ca64a2569667..9ad36ee2b313 100644 --- a/.github/workflows/dependency-review.yml +++ b/.github/workflows/dependency-review.yml @@ -22,6 +22,6 @@ jobs: egress-policy: audit # TODO: change to 'egress-policy: block' after couple of runs - name: 'Checkout Repository' - uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938 # v4.2.0 + uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 # v4.2.1 - name: 'Dependency Review' uses: actions/dependency-review-action@5a2ce3f5b92ee19cbb1541a4984c76d921601d7c # v4.3.4 diff --git a/.github/workflows/release-tagger.yml b/.github/workflows/release-tagger.yml index eb386d4aa541..13c821d93ffe 100644 --- a/.github/workflows/release-tagger.yml +++ b/.github/workflows/release-tagger.yml @@ -33,7 +33,7 @@ jobs: - uses: actions/setup-node@0a44ba7841725637a19e28fa30b79a866c81b0a6 # v4.0.4 with: node-version: lts/* - - uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938 # v4.2.0 + - uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 # v4.2.1 - run: bash ./.github/workflows/install_dependencies.sh - name: Run tagger run: | @@ -60,7 +60,7 @@ jobs: with: egress-policy: audit # TODO: change to 'egress-policy: block' after couple of runs - - uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938 # v4.2.0 + - uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 # v4.2.1 - name: Create issue on error uses: JasonEtco/create-an-issue@1b14a70e4d8dc185e5cc76d3bec9eab20257b2c5 # v2.9.2 diff --git a/.github/workflows/scorecard.yml b/.github/workflows/scorecard.yml index 3923f6b9c949..2ee7174d0e7c 100644 --- a/.github/workflows/scorecard.yml +++ b/.github/workflows/scorecard.yml @@ -37,7 +37,7 @@ jobs: egress-policy: audit # TODO: change to 'egress-policy: block' after couple of runs - name: 'Checkout code' - uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938 # v4.2.0 + uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 # v4.2.1 with: persist-credentials: false @@ -64,7 +64,7 @@ jobs: # Upload the results as artifacts (optional). Commenting out will disable uploads of run results in SARIF # format to the repository Actions tab. - name: 'Upload artifact' - uses: actions/upload-artifact@50769540e7f4bd5e21e526ee35c689e35e0d6874 # v4.4.0 + uses: actions/upload-artifact@604373da6381bf24206979c74d06a550515601b9 # v4.4.1 with: name: SARIF file path: results.sarif @@ -72,6 +72,6 @@ jobs: # Upload the results to GitHub's code scanning dashboard. - name: 'Upload to code-scanning' - uses: github/codeql-action/upload-sarif@6db8d6351fd0be61f9ed8ebd12ccd35dcec51fea # v3.26.11 + uses: github/codeql-action/upload-sarif@c36620d31ac7c881962c3d9dd939c40ec9434f2b # v3.26.12 with: sarif_file: results.sarif diff --git a/.github/workflows/status-page.yml b/.github/workflows/status-page.yml index 469a73a375f8..1d126e19f1c0 100644 --- a/.github/workflows/status-page.yml +++ b/.github/workflows/status-page.yml @@ -21,7 +21,7 @@ jobs: - uses: actions/setup-node@0a44ba7841725637a19e28fa30b79a866c81b0a6 # v4.0.4 with: node-version: lts/* - - uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938 # v4.2.0 + - uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 # v4.2.1 - name: Add progress comment to cherry-pick issue for Stable and LTS if: github.event_name == 'issues' && github.event.action == 'opened' run: | @@ -56,7 +56,7 @@ jobs: with: egress-policy: audit # TODO: change to 'egress-policy: block' after couple of runs - - uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938 # v4.2.0 + - uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 # v4.2.1 - name: Create issue on error uses: JasonEtco/create-an-issue@1b14a70e4d8dc185e5cc76d3bec9eab20257b2c5 # v2.9.2 diff --git a/.github/workflows/update-session-issues.yml b/.github/workflows/update-session-issues.yml index b0645bbafa26..2f22bca167b6 100644 --- a/.github/workflows/update-session-issues.yml +++ b/.github/workflows/update-session-issues.yml @@ -26,7 +26,7 @@ jobs: egress-policy: audit # TODO: change to 'egress-policy: block' after couple of runs - name: Checkout Repo - uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938 # v4.2.0 + uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 # v4.2.1 - name: Update Session Issues run: | node ./build-system/common/update-session-issues diff --git a/third_party/amp-toolbox-cache-url/package.json b/third_party/amp-toolbox-cache-url/package.json index 02a905ad40fd..3c75c21bff1f 100644 --- a/third_party/amp-toolbox-cache-url/package.json +++ b/third_party/amp-toolbox-cache-url/package.json @@ -33,7 +33,7 @@ }, "devDependencies": { "@ampproject/rollup-plugin-closure-compiler": "0.27.0", - "eslint": "9.11.1", + "eslint": "9.12.0", "eslint-config-google": "0.14.0", "jasmine": "5.3.1", "karma": "6.4.4", From 7cc4804a56df39c93eb7930ab9d94a70ef25d45d Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Tue, 15 Oct 2024 12:53:25 -0400 Subject: [PATCH 02/12] =?UTF-8?q?=F0=9F=93=A6=20Update=20build-system=20de?= =?UTF-8?q?vDependencies=20(#40184)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> --- build-system/tasks/e2e/package-lock.json | 14 +- build-system/tasks/e2e/package.json | 2 +- .../tasks/storybook/env/amp/package-lock.json | 8 +- .../tasks/storybook/env/amp/package.json | 2 +- .../storybook/env/preact/package-lock.json | 14 +- .../tasks/storybook/env/preact/package.json | 2 +- .../tasks/storybook/package-lock.json | 26 +-- build-system/tasks/storybook/package.json | 2 +- .../tasks/visual-diff/package-lock.json | 158 +++++++++--------- build-system/tasks/visual-diff/package.json | 6 +- 10 files changed, 117 insertions(+), 117 deletions(-) diff --git a/build-system/tasks/e2e/package-lock.json b/build-system/tasks/e2e/package-lock.json index 928842adc632..d8c61a454033 100644 --- a/build-system/tasks/e2e/package-lock.json +++ b/build-system/tasks/e2e/package-lock.json @@ -12,7 +12,7 @@ "@types/selenium-webdriver": "4.1.26", "babel-regenerator-runtime": "6.5.0", "chromedriver": "119.0.1", - "geckodriver": "4.5.0", + "geckodriver": "4.5.1", "selenium-webdriver": "4.25.0" } }, @@ -1033,9 +1033,9 @@ } }, "node_modules/geckodriver": { - "version": "4.5.0", - "resolved": "https://registry.npmjs.org/geckodriver/-/geckodriver-4.5.0.tgz", - "integrity": "sha512-EnBCT9kJ5oEoP3DaJKjzxAhm7bbNNK6k2q7oCkCT58OIOOiE6Hsr+nVDHflsNaR68HMGtBKOLSZ+YvCDHecScw==", + "version": "4.5.1", + "resolved": "https://registry.npmjs.org/geckodriver/-/geckodriver-4.5.1.tgz", + "integrity": "sha512-lGCRqPMuzbRNDWJOQcUqhNqPvNsIFu6yzXF8J/6K3WCYFd2r5ckbeF7h1cxsnjA7YLSEiWzERCt6/gjZ3tW0ug==", "dev": true, "hasInstallScript": true, "dependencies": { @@ -2587,9 +2587,9 @@ } }, "geckodriver": { - "version": "4.5.0", - "resolved": "https://registry.npmjs.org/geckodriver/-/geckodriver-4.5.0.tgz", - "integrity": "sha512-EnBCT9kJ5oEoP3DaJKjzxAhm7bbNNK6k2q7oCkCT58OIOOiE6Hsr+nVDHflsNaR68HMGtBKOLSZ+YvCDHecScw==", + "version": "4.5.1", + "resolved": "https://registry.npmjs.org/geckodriver/-/geckodriver-4.5.1.tgz", + "integrity": "sha512-lGCRqPMuzbRNDWJOQcUqhNqPvNsIFu6yzXF8J/6K3WCYFd2r5ckbeF7h1cxsnjA7YLSEiWzERCt6/gjZ3tW0ug==", "dev": true, "requires": { "@wdio/logger": "^9.0.0", diff --git a/build-system/tasks/e2e/package.json b/build-system/tasks/e2e/package.json index c4ba4334ba45..103d0c271b4e 100644 --- a/build-system/tasks/e2e/package.json +++ b/build-system/tasks/e2e/package.json @@ -8,7 +8,7 @@ "@types/selenium-webdriver": "4.1.26", "babel-regenerator-runtime": "6.5.0", "chromedriver": "119.0.1", - "geckodriver": "4.5.0", + "geckodriver": "4.5.1", "selenium-webdriver": "4.25.0" } } diff --git a/build-system/tasks/storybook/env/amp/package-lock.json b/build-system/tasks/storybook/env/amp/package-lock.json index 39f3beb09798..9fcc25829a90 100644 --- a/build-system/tasks/storybook/env/amp/package-lock.json +++ b/build-system/tasks/storybook/env/amp/package-lock.json @@ -9,7 +9,7 @@ "version": "0.1.0", "devDependencies": { "@ampproject/storybook-addon": "1.1.10", - "preact": "10.24.2" + "preact": "10.24.3" } }, "node_modules/@ampproject/storybook-addon": { @@ -1596,9 +1596,9 @@ } }, "node_modules/preact": { - "version": "10.24.2", - "resolved": "https://registry.npmjs.org/preact/-/preact-10.24.2.tgz", - "integrity": "sha512-1cSoF0aCC8uaARATfrlz4VCBqE8LwZwRfLgkxJOQwAlQt6ayTmi0D9OF7nXid1POI5SZidFuG9CnlXbDfLqY/Q==", + "version": "10.24.3", + "resolved": "https://registry.npmjs.org/preact/-/preact-10.24.3.tgz", + "integrity": "sha512-Z2dPnBnMUfyQfSQ+GBdsGa16hz35YmLmtTLhM169uW944hYL6xzTYkJjC07j+Wosz733pMWx0fgON3JNw1jJQA==", "dev": true, "license": "MIT", "funding": { diff --git a/build-system/tasks/storybook/env/amp/package.json b/build-system/tasks/storybook/env/amp/package.json index 28be537b8fe3..ab50772f262e 100644 --- a/build-system/tasks/storybook/env/amp/package.json +++ b/build-system/tasks/storybook/env/amp/package.json @@ -4,6 +4,6 @@ "description": "packages specific to the amp storybook env", "devDependencies": { "@ampproject/storybook-addon": "1.1.10", - "preact": "10.24.2" + "preact": "10.24.3" } } diff --git a/build-system/tasks/storybook/env/preact/package-lock.json b/build-system/tasks/storybook/env/preact/package-lock.json index d7a328199593..3600bd6ec0a7 100644 --- a/build-system/tasks/storybook/env/preact/package-lock.json +++ b/build-system/tasks/storybook/env/preact/package-lock.json @@ -8,13 +8,13 @@ "name": "amp-storybook-preact", "version": "0.1.0", "devDependencies": { - "preact": "10.24.2" + "preact": "10.24.3" } }, "node_modules/preact": { - "version": "10.24.2", - "resolved": "https://registry.npmjs.org/preact/-/preact-10.24.2.tgz", - "integrity": "sha512-1cSoF0aCC8uaARATfrlz4VCBqE8LwZwRfLgkxJOQwAlQt6ayTmi0D9OF7nXid1POI5SZidFuG9CnlXbDfLqY/Q==", + "version": "10.24.3", + "resolved": "https://registry.npmjs.org/preact/-/preact-10.24.3.tgz", + "integrity": "sha512-Z2dPnBnMUfyQfSQ+GBdsGa16hz35YmLmtTLhM169uW944hYL6xzTYkJjC07j+Wosz733pMWx0fgON3JNw1jJQA==", "dev": true, "funding": { "type": "opencollective", @@ -24,9 +24,9 @@ }, "dependencies": { "preact": { - "version": "10.24.2", - "resolved": "https://registry.npmjs.org/preact/-/preact-10.24.2.tgz", - "integrity": "sha512-1cSoF0aCC8uaARATfrlz4VCBqE8LwZwRfLgkxJOQwAlQt6ayTmi0D9OF7nXid1POI5SZidFuG9CnlXbDfLqY/Q==", + "version": "10.24.3", + "resolved": "https://registry.npmjs.org/preact/-/preact-10.24.3.tgz", + "integrity": "sha512-Z2dPnBnMUfyQfSQ+GBdsGa16hz35YmLmtTLhM169uW944hYL6xzTYkJjC07j+Wosz733pMWx0fgON3JNw1jJQA==", "dev": true } } diff --git a/build-system/tasks/storybook/env/preact/package.json b/build-system/tasks/storybook/env/preact/package.json index 83e0c9791b81..a5655a69958e 100644 --- a/build-system/tasks/storybook/env/preact/package.json +++ b/build-system/tasks/storybook/env/preact/package.json @@ -3,6 +3,6 @@ "version": "0.1.0", "description": "packages specific to the preact storybook env", "devDependencies": { - "preact": "10.24.2" + "preact": "10.24.3" } } diff --git a/build-system/tasks/storybook/package-lock.json b/build-system/tasks/storybook/package-lock.json index 6e591f295cf2..7e78d3d3c15f 100644 --- a/build-system/tasks/storybook/package-lock.json +++ b/build-system/tasks/storybook/package-lock.json @@ -8,7 +8,7 @@ "name": "amp-storybook", "version": "0.1.0", "devDependencies": { - "@babel/core": "7.25.7", + "@babel/core": "7.25.8", "@babel/preset-react": "7.25.7", "@storybook/addon-a11y": "8.3.5", "@storybook/addon-controls": "8.3.5", @@ -54,9 +54,9 @@ } }, "node_modules/@babel/core": { - "version": "7.25.7", - "resolved": "https://registry.npmjs.org/@babel/core/-/core-7.25.7.tgz", - "integrity": "sha512-yJ474Zv3cwiSOO9nXJuqzvwEeM+chDuQ8GJirw+pZ91sCGCyOZ3dJkVE09fTV0VEVzXyLWhh3G/AolYTPX7Mow==", + "version": "7.25.8", + "resolved": "https://registry.npmjs.org/@babel/core/-/core-7.25.8.tgz", + "integrity": "sha512-Oixnb+DzmRT30qu9d3tJSQkxuygWm32DFykT4bRoORPa9hZ/L4KhVB/XiRm6KG+roIEM7DBQlmg27kw2HZkdZg==", "dev": true, "license": "MIT", "dependencies": { @@ -66,10 +66,10 @@ "@babel/helper-compilation-targets": "^7.25.7", "@babel/helper-module-transforms": "^7.25.7", "@babel/helpers": "^7.25.7", - "@babel/parser": "^7.25.7", + "@babel/parser": "^7.25.8", "@babel/template": "^7.25.7", "@babel/traverse": "^7.25.7", - "@babel/types": "^7.25.7", + "@babel/types": "^7.25.8", "convert-source-map": "^2.0.0", "debug": "^4.1.0", "gensync": "^1.0.0-beta.2", @@ -248,13 +248,13 @@ } }, "node_modules/@babel/parser": { - "version": "7.25.7", - "resolved": "https://registry.npmjs.org/@babel/parser/-/parser-7.25.7.tgz", - "integrity": "sha512-aZn7ETtQsjjGG5HruveUK06cU3Hljuhd9Iojm4M8WWv3wLE6OkE5PWbDUkItmMgegmccaITudyuW5RPYrYlgWw==", + "version": "7.25.8", + "resolved": "https://registry.npmjs.org/@babel/parser/-/parser-7.25.8.tgz", + "integrity": "sha512-HcttkxzdPucv3nNFmfOOMfFf64KgdJVqm1KaCm25dPGMLElo9nsLvXeJECQg8UzPuBGLyTSA0ZzqCtDSzKTEoQ==", "dev": true, "license": "MIT", "dependencies": { - "@babel/types": "^7.25.7" + "@babel/types": "^7.25.8" }, "bin": { "parser": "bin/babel-parser.js" @@ -404,9 +404,9 @@ } }, "node_modules/@babel/types": { - "version": "7.25.7", - "resolved": "https://registry.npmjs.org/@babel/types/-/types-7.25.7.tgz", - "integrity": "sha512-vwIVdXG+j+FOpkwqHRcBgHLYNL7XMkufrlaFvL9o6Ai9sJn9+PdyIL5qa0XzTZw084c+u9LOls53eoZWP/W5WQ==", + "version": "7.25.8", + "resolved": "https://registry.npmjs.org/@babel/types/-/types-7.25.8.tgz", + "integrity": "sha512-JWtuCu8VQsMladxVz/P4HzHUGCAwpuqacmowgXFs5XjxIgKuNjnLokQzuVjlTvIzODaDmpjT3oxcC48vyk9EWg==", "dev": true, "license": "MIT", "dependencies": { diff --git a/build-system/tasks/storybook/package.json b/build-system/tasks/storybook/package.json index 923b6f1f0654..59ae5d1fd60d 100644 --- a/build-system/tasks/storybook/package.json +++ b/build-system/tasks/storybook/package.json @@ -3,7 +3,7 @@ "version": "0.1.0", "description": "amp storybook task", "devDependencies": { - "@babel/core": "7.25.7", + "@babel/core": "7.25.8", "@babel/preset-react": "7.25.7", "@storybook/addon-a11y": "8.3.5", "@storybook/addon-controls": "8.3.5", diff --git a/build-system/tasks/visual-diff/package-lock.json b/build-system/tasks/visual-diff/package-lock.json index 8d8ed4c575fa..a3cf6e0584da 100644 --- a/build-system/tasks/visual-diff/package-lock.json +++ b/build-system/tasks/visual-diff/package-lock.json @@ -9,11 +9,11 @@ "version": "0.1.0", "devDependencies": { "@inquirer/prompts": "7.0.0", - "@percy/core": "1.30.0", + "@percy/core": "1.30.1", "@percy/puppeteer": "2.0.2", - "@percy/sdk-utils": "1.30.0", + "@percy/sdk-utils": "1.30.1", "@puppeteer/browsers": "2.4.0", - "puppeteer-core": "23.5.1" + "puppeteer-core": "23.5.3" } }, "node_modules/@babel/code-frame": { @@ -291,13 +291,13 @@ } }, "node_modules/@percy/client": { - "version": "1.30.0", - "resolved": "https://registry.npmjs.org/@percy/client/-/client-1.30.0.tgz", - "integrity": "sha512-kNAoa07QtlIHvail0+vjd0xfvO4OxI97fV73pefe6PtJ1u3Cze+q4DEFPWxcJ39wjUD4C2f3TgJ2CzhEm53yiw==", + "version": "1.30.1", + "resolved": "https://registry.npmjs.org/@percy/client/-/client-1.30.1.tgz", + "integrity": "sha512-vaue3/dOykOWZ9ER/vecb9mkcuTe72wgCrYbzIcKNtSUc5AQEGiV5c8rGZav868i5YCtGejexWZ7PKDO05asag==", "dev": true, "dependencies": { - "@percy/env": "1.30.0", - "@percy/logger": "1.30.0", + "@percy/env": "1.30.1", + "@percy/logger": "1.30.1", "pako": "^2.1.0" }, "engines": { @@ -305,12 +305,12 @@ } }, "node_modules/@percy/config": { - "version": "1.30.0", - "resolved": "https://registry.npmjs.org/@percy/config/-/config-1.30.0.tgz", - "integrity": "sha512-mOhLn9fqQTMgXA8Li1UxjZCcLQcokeQtsedlCXdzzt2QbS9DFcV3koMyooabOO6MsCNh4wI7J/zcXu08c4H9Vw==", + "version": "1.30.1", + "resolved": "https://registry.npmjs.org/@percy/config/-/config-1.30.1.tgz", + "integrity": "sha512-wvI2QIf7/oLPsnrXGHFCLRdDY5BRFE3Smil8IY2ijtGUFWXRPsmRx2tjSdbZ/kpctkeyZappNHPzSiwi1MjJlA==", "dev": true, "dependencies": { - "@percy/logger": "1.30.0", + "@percy/logger": "1.30.1", "ajv": "^8.6.2", "cosmiconfig": "^8.0.0", "yaml": "^2.0.0" @@ -320,17 +320,17 @@ } }, "node_modules/@percy/core": { - "version": "1.30.0", - "resolved": "https://registry.npmjs.org/@percy/core/-/core-1.30.0.tgz", - "integrity": "sha512-MeAhFWCf97xVvx8c6XsSpC+uWRbM0RE5llXmC7U5JH2cYZXoyzul2eZacYUmQJPVzEaWduXLDCukYIa0nDo1+A==", + "version": "1.30.1", + "resolved": "https://registry.npmjs.org/@percy/core/-/core-1.30.1.tgz", + "integrity": "sha512-XQNPFO8ZmKWMMkWaa+IWN6Kzh7CXCwosLWK7OsEldK7N/CVNGmU8mkCwpqYlDXEeiahGfUxqCr4yHZS26OveyQ==", "dev": true, "hasInstallScript": true, "dependencies": { - "@percy/client": "1.30.0", - "@percy/config": "1.30.0", - "@percy/dom": "1.30.0", - "@percy/logger": "1.30.0", - "@percy/webdriver-utils": "1.30.0", + "@percy/client": "1.30.1", + "@percy/config": "1.30.1", + "@percy/dom": "1.30.1", + "@percy/logger": "1.30.1", + "@percy/webdriver-utils": "1.30.1", "content-disposition": "^0.5.4", "cross-spawn": "^7.0.3", "extract-zip": "^2.0.1", @@ -348,27 +348,27 @@ } }, "node_modules/@percy/dom": { - "version": "1.30.0", - "resolved": "https://registry.npmjs.org/@percy/dom/-/dom-1.30.0.tgz", - "integrity": "sha512-i3uHFDAzXCLAeI0oTDDWIaRq1wiGwoRknS1QfIfy7usAia+ipeWhWb+m3sXtfg/g6WyBzcg3OtG1tIB8TO7/4g==", + "version": "1.30.1", + "resolved": "https://registry.npmjs.org/@percy/dom/-/dom-1.30.1.tgz", + "integrity": "sha512-dYHVGETIXzwqchShfzOkCrGCqjw/KLsubUZR3PYWd6UtTWZ9kFWr9I6MzizPE4XfhJs5rQ0e0Keb29FrGTey5Q==", "dev": true }, "node_modules/@percy/env": { - "version": "1.30.0", - "resolved": "https://registry.npmjs.org/@percy/env/-/env-1.30.0.tgz", - "integrity": "sha512-+h7c0lxB01bnymTZfM24RrjMIL28rQWeT4aQ/BJVlvAELstZaYwl0vv8RrAtBUKnSZaXUkNIOWZtgFiuer/y0g==", + "version": "1.30.1", + "resolved": "https://registry.npmjs.org/@percy/env/-/env-1.30.1.tgz", + "integrity": "sha512-ib9Ty/zo/+kfQSRC7RyzxnrS5zzsaoWJLgvTUDwi4iv/UIvx6vrEp7YPE0FQu1VGoRoL7zxRKalTh06/kBAsXg==", "dev": true, "dependencies": { - "@percy/logger": "1.30.0" + "@percy/logger": "1.30.1" }, "engines": { "node": ">=14" } }, "node_modules/@percy/logger": { - "version": "1.30.0", - "resolved": "https://registry.npmjs.org/@percy/logger/-/logger-1.30.0.tgz", - "integrity": "sha512-p5ZxD9fFRjCiMF630xIDRv2hPH70TI20r9yIyHgjmCM4ES0Cfu+61gaRpiSaay0DWKfG6iwpmUhZsKafRMSYCw==", + "version": "1.30.1", + "resolved": "https://registry.npmjs.org/@percy/logger/-/logger-1.30.1.tgz", + "integrity": "sha512-FaVW4YGmgPaW0OviMFUn7m7ski2uZQAeUJ/hg+IXFIN+zSreX2ORcsp+Fep2p+h5UjcZX5wFuf/8O3nth5YAfQ==", "dev": true, "engines": { "node": ">=14" @@ -390,22 +390,22 @@ } }, "node_modules/@percy/sdk-utils": { - "version": "1.30.0", - "resolved": "https://registry.npmjs.org/@percy/sdk-utils/-/sdk-utils-1.30.0.tgz", - "integrity": "sha512-GPEexJ0gxiFXqjFpL8EtILZo/arrwdz96oyZMsCeRu9bVSQ8ZvptFlwO8hYKtXvZcY7CJfGnUyOcza8CYPxM3g==", + "version": "1.30.1", + "resolved": "https://registry.npmjs.org/@percy/sdk-utils/-/sdk-utils-1.30.1.tgz", + "integrity": "sha512-xdeaHEdQvytFEbNBYCFdu1ToD6T/BT6YtZYwfNKAYXwQqVbm4wr/3LVH+GUcxYZsBCxmeSyCrF4buspUhxTNJQ==", "dev": true, "engines": { "node": ">=14" } }, "node_modules/@percy/webdriver-utils": { - "version": "1.30.0", - "resolved": "https://registry.npmjs.org/@percy/webdriver-utils/-/webdriver-utils-1.30.0.tgz", - "integrity": "sha512-93S0U1enM9mHR99iEjPSekrZc3/DI+GYYXicvM8nFD9FHlXuMbykHCU0hKJAZF/IvlucVnH04s3yomn/58cXAw==", + "version": "1.30.1", + "resolved": "https://registry.npmjs.org/@percy/webdriver-utils/-/webdriver-utils-1.30.1.tgz", + "integrity": "sha512-mXY40mUBLsdwFMKsZpg87K457a76Qi0Dq8+nZ0rLqYj5STZs3RQWbgi9qMI3ELoB3BqLzePqR9pL8J9WjvRXDg==", "dev": true, "dependencies": { - "@percy/config": "1.30.0", - "@percy/sdk-utils": "1.30.0" + "@percy/config": "1.30.1", + "@percy/sdk-utils": "1.30.1" }, "engines": { "node": ">=14" @@ -1766,9 +1766,9 @@ } }, "node_modules/puppeteer-core": { - "version": "23.5.1", - "resolved": "https://registry.npmjs.org/puppeteer-core/-/puppeteer-core-23.5.1.tgz", - "integrity": "sha512-We6xKCSZaZ23+GAYckeNfeDeJIVuhxOBsh/gZkbULu/XLFJ3umSiiQ8Ey927h3g/XrCCr8CnSZ5fvP5v2vB5Yw==", + "version": "23.5.3", + "resolved": "https://registry.npmjs.org/puppeteer-core/-/puppeteer-core-23.5.3.tgz", + "integrity": "sha512-V58MZD/B3CwkYsqSEQlHKbavMJptF04fzhMdUpiCRCmUVhwZNwSGEPhaiZ1f8I3ABQUirg3VNhXVB6Z1ubHXtQ==", "dev": true, "dependencies": { "@puppeteer/browsers": "2.4.0", @@ -2648,39 +2648,39 @@ } }, "@percy/client": { - "version": "1.30.0", - "resolved": "https://registry.npmjs.org/@percy/client/-/client-1.30.0.tgz", - "integrity": "sha512-kNAoa07QtlIHvail0+vjd0xfvO4OxI97fV73pefe6PtJ1u3Cze+q4DEFPWxcJ39wjUD4C2f3TgJ2CzhEm53yiw==", + "version": "1.30.1", + "resolved": "https://registry.npmjs.org/@percy/client/-/client-1.30.1.tgz", + "integrity": "sha512-vaue3/dOykOWZ9ER/vecb9mkcuTe72wgCrYbzIcKNtSUc5AQEGiV5c8rGZav868i5YCtGejexWZ7PKDO05asag==", "dev": true, "requires": { - "@percy/env": "1.30.0", - "@percy/logger": "1.30.0", + "@percy/env": "1.30.1", + "@percy/logger": "1.30.1", "pako": "^2.1.0" } }, "@percy/config": { - "version": "1.30.0", - "resolved": "https://registry.npmjs.org/@percy/config/-/config-1.30.0.tgz", - "integrity": "sha512-mOhLn9fqQTMgXA8Li1UxjZCcLQcokeQtsedlCXdzzt2QbS9DFcV3koMyooabOO6MsCNh4wI7J/zcXu08c4H9Vw==", + "version": "1.30.1", + "resolved": "https://registry.npmjs.org/@percy/config/-/config-1.30.1.tgz", + "integrity": "sha512-wvI2QIf7/oLPsnrXGHFCLRdDY5BRFE3Smil8IY2ijtGUFWXRPsmRx2tjSdbZ/kpctkeyZappNHPzSiwi1MjJlA==", "dev": true, "requires": { - "@percy/logger": "1.30.0", + "@percy/logger": "1.30.1", "ajv": "^8.6.2", "cosmiconfig": "^8.0.0", "yaml": "^2.0.0" } }, "@percy/core": { - "version": "1.30.0", - "resolved": "https://registry.npmjs.org/@percy/core/-/core-1.30.0.tgz", - "integrity": "sha512-MeAhFWCf97xVvx8c6XsSpC+uWRbM0RE5llXmC7U5JH2cYZXoyzul2eZacYUmQJPVzEaWduXLDCukYIa0nDo1+A==", + "version": "1.30.1", + "resolved": "https://registry.npmjs.org/@percy/core/-/core-1.30.1.tgz", + "integrity": "sha512-XQNPFO8ZmKWMMkWaa+IWN6Kzh7CXCwosLWK7OsEldK7N/CVNGmU8mkCwpqYlDXEeiahGfUxqCr4yHZS26OveyQ==", "dev": true, "requires": { - "@percy/client": "1.30.0", - "@percy/config": "1.30.0", - "@percy/dom": "1.30.0", - "@percy/logger": "1.30.0", - "@percy/webdriver-utils": "1.30.0", + "@percy/client": "1.30.1", + "@percy/config": "1.30.1", + "@percy/dom": "1.30.1", + "@percy/logger": "1.30.1", + "@percy/webdriver-utils": "1.30.1", "content-disposition": "^0.5.4", "cross-spawn": "^7.0.3", "extract-zip": "^2.0.1", @@ -2695,24 +2695,24 @@ } }, "@percy/dom": { - "version": "1.30.0", - "resolved": "https://registry.npmjs.org/@percy/dom/-/dom-1.30.0.tgz", - "integrity": "sha512-i3uHFDAzXCLAeI0oTDDWIaRq1wiGwoRknS1QfIfy7usAia+ipeWhWb+m3sXtfg/g6WyBzcg3OtG1tIB8TO7/4g==", + "version": "1.30.1", + "resolved": "https://registry.npmjs.org/@percy/dom/-/dom-1.30.1.tgz", + "integrity": "sha512-dYHVGETIXzwqchShfzOkCrGCqjw/KLsubUZR3PYWd6UtTWZ9kFWr9I6MzizPE4XfhJs5rQ0e0Keb29FrGTey5Q==", "dev": true }, "@percy/env": { - "version": "1.30.0", - "resolved": "https://registry.npmjs.org/@percy/env/-/env-1.30.0.tgz", - "integrity": "sha512-+h7c0lxB01bnymTZfM24RrjMIL28rQWeT4aQ/BJVlvAELstZaYwl0vv8RrAtBUKnSZaXUkNIOWZtgFiuer/y0g==", + "version": "1.30.1", + "resolved": "https://registry.npmjs.org/@percy/env/-/env-1.30.1.tgz", + "integrity": "sha512-ib9Ty/zo/+kfQSRC7RyzxnrS5zzsaoWJLgvTUDwi4iv/UIvx6vrEp7YPE0FQu1VGoRoL7zxRKalTh06/kBAsXg==", "dev": true, "requires": { - "@percy/logger": "1.30.0" + "@percy/logger": "1.30.1" } }, "@percy/logger": { - "version": "1.30.0", - "resolved": "https://registry.npmjs.org/@percy/logger/-/logger-1.30.0.tgz", - "integrity": "sha512-p5ZxD9fFRjCiMF630xIDRv2hPH70TI20r9yIyHgjmCM4ES0Cfu+61gaRpiSaay0DWKfG6iwpmUhZsKafRMSYCw==", + "version": "1.30.1", + "resolved": "https://registry.npmjs.org/@percy/logger/-/logger-1.30.1.tgz", + "integrity": "sha512-FaVW4YGmgPaW0OviMFUn7m7ski2uZQAeUJ/hg+IXFIN+zSreX2ORcsp+Fep2p+h5UjcZX5wFuf/8O3nth5YAfQ==", "dev": true }, "@percy/puppeteer": { @@ -2725,19 +2725,19 @@ } }, "@percy/sdk-utils": { - "version": "1.30.0", - "resolved": "https://registry.npmjs.org/@percy/sdk-utils/-/sdk-utils-1.30.0.tgz", - "integrity": "sha512-GPEexJ0gxiFXqjFpL8EtILZo/arrwdz96oyZMsCeRu9bVSQ8ZvptFlwO8hYKtXvZcY7CJfGnUyOcza8CYPxM3g==", + "version": "1.30.1", + "resolved": "https://registry.npmjs.org/@percy/sdk-utils/-/sdk-utils-1.30.1.tgz", + "integrity": "sha512-xdeaHEdQvytFEbNBYCFdu1ToD6T/BT6YtZYwfNKAYXwQqVbm4wr/3LVH+GUcxYZsBCxmeSyCrF4buspUhxTNJQ==", "dev": true }, "@percy/webdriver-utils": { - "version": "1.30.0", - "resolved": "https://registry.npmjs.org/@percy/webdriver-utils/-/webdriver-utils-1.30.0.tgz", - "integrity": "sha512-93S0U1enM9mHR99iEjPSekrZc3/DI+GYYXicvM8nFD9FHlXuMbykHCU0hKJAZF/IvlucVnH04s3yomn/58cXAw==", + "version": "1.30.1", + "resolved": "https://registry.npmjs.org/@percy/webdriver-utils/-/webdriver-utils-1.30.1.tgz", + "integrity": "sha512-mXY40mUBLsdwFMKsZpg87K457a76Qi0Dq8+nZ0rLqYj5STZs3RQWbgi9qMI3ELoB3BqLzePqR9pL8J9WjvRXDg==", "dev": true, "requires": { - "@percy/config": "1.30.0", - "@percy/sdk-utils": "1.30.0" + "@percy/config": "1.30.1", + "@percy/sdk-utils": "1.30.1" } }, "@puppeteer/browsers": { @@ -3794,9 +3794,9 @@ } }, "puppeteer-core": { - "version": "23.5.1", - "resolved": "https://registry.npmjs.org/puppeteer-core/-/puppeteer-core-23.5.1.tgz", - "integrity": "sha512-We6xKCSZaZ23+GAYckeNfeDeJIVuhxOBsh/gZkbULu/XLFJ3umSiiQ8Ey927h3g/XrCCr8CnSZ5fvP5v2vB5Yw==", + "version": "23.5.3", + "resolved": "https://registry.npmjs.org/puppeteer-core/-/puppeteer-core-23.5.3.tgz", + "integrity": "sha512-V58MZD/B3CwkYsqSEQlHKbavMJptF04fzhMdUpiCRCmUVhwZNwSGEPhaiZ1f8I3ABQUirg3VNhXVB6Z1ubHXtQ==", "dev": true, "requires": { "@puppeteer/browsers": "2.4.0", diff --git a/build-system/tasks/visual-diff/package.json b/build-system/tasks/visual-diff/package.json index 71655c1590f3..a7d2c15cb6b9 100644 --- a/build-system/tasks/visual-diff/package.json +++ b/build-system/tasks/visual-diff/package.json @@ -5,10 +5,10 @@ "description": "amp visual diff", "devDependencies": { "@inquirer/prompts": "7.0.0", - "@percy/core": "1.30.0", + "@percy/core": "1.30.1", "@percy/puppeteer": "2.0.2", - "@percy/sdk-utils": "1.30.0", + "@percy/sdk-utils": "1.30.1", "@puppeteer/browsers": "2.4.0", - "puppeteer-core": "23.5.1" + "puppeteer-core": "23.5.3" } } From c9f553935c407ee786c120d3d4b60d42d8306d2d Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Wed, 16 Oct 2024 13:49:43 -0400 Subject: [PATCH 03/12] =?UTF-8?q?=F0=9F=93=A6=20Update=20dependency=20pupp?= =?UTF-8?q?eteer-core=20to=20v23.6.0=20(#40186)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> --- .../tasks/visual-diff/package-lock.json | 30 +++++++++---------- build-system/tasks/visual-diff/package.json | 2 +- 2 files changed, 16 insertions(+), 16 deletions(-) diff --git a/build-system/tasks/visual-diff/package-lock.json b/build-system/tasks/visual-diff/package-lock.json index a3cf6e0584da..eafbb0a017d1 100644 --- a/build-system/tasks/visual-diff/package-lock.json +++ b/build-system/tasks/visual-diff/package-lock.json @@ -13,7 +13,7 @@ "@percy/puppeteer": "2.0.2", "@percy/sdk-utils": "1.30.1", "@puppeteer/browsers": "2.4.0", - "puppeteer-core": "23.5.3" + "puppeteer-core": "23.6.0" } }, "node_modules/@babel/code-frame": { @@ -1766,15 +1766,15 @@ } }, "node_modules/puppeteer-core": { - "version": "23.5.3", - "resolved": "https://registry.npmjs.org/puppeteer-core/-/puppeteer-core-23.5.3.tgz", - "integrity": "sha512-V58MZD/B3CwkYsqSEQlHKbavMJptF04fzhMdUpiCRCmUVhwZNwSGEPhaiZ1f8I3ABQUirg3VNhXVB6Z1ubHXtQ==", + "version": "23.6.0", + "resolved": "https://registry.npmjs.org/puppeteer-core/-/puppeteer-core-23.6.0.tgz", + "integrity": "sha512-se1bhgUpR9C529SgHGr/eyT92mYyQPAhA2S9pGtGrVG2xob9qE6Pbp7TlqiSPlnnY1lINqhn6/67EwkdzOmKqQ==", "dev": true, "dependencies": { "@puppeteer/browsers": "2.4.0", "chromium-bidi": "0.8.0", "debug": "^4.3.7", - "devtools-protocol": "0.0.1342118", + "devtools-protocol": "0.0.1354347", "typed-query-selector": "^2.12.0", "ws": "^8.18.0" }, @@ -1797,9 +1797,9 @@ } }, "node_modules/puppeteer-core/node_modules/devtools-protocol": { - "version": "0.0.1342118", - "resolved": "https://registry.npmjs.org/devtools-protocol/-/devtools-protocol-0.0.1342118.tgz", - "integrity": "sha512-75fMas7PkYNDTmDyb6PRJCH7ILmHLp+BhrZGeMsa4bCh40DTxgCz2NRy5UDzII4C5KuD0oBMZ9vXKhEl6UD/3w==", + "version": "0.0.1354347", + "resolved": "https://registry.npmjs.org/devtools-protocol/-/devtools-protocol-0.0.1354347.tgz", + "integrity": "sha512-BlmkSqV0V84E2WnEnoPnwyix57rQxAM5SKJjf4TbYOCGLAWtz8CDH8RIaGOjPgPCXo2Mce3kxSY497OySidY3Q==", "dev": true }, "node_modules/puppeteer/node_modules/@puppeteer/browsers": { @@ -3794,15 +3794,15 @@ } }, "puppeteer-core": { - "version": "23.5.3", - "resolved": "https://registry.npmjs.org/puppeteer-core/-/puppeteer-core-23.5.3.tgz", - "integrity": "sha512-V58MZD/B3CwkYsqSEQlHKbavMJptF04fzhMdUpiCRCmUVhwZNwSGEPhaiZ1f8I3ABQUirg3VNhXVB6Z1ubHXtQ==", + "version": "23.6.0", + "resolved": "https://registry.npmjs.org/puppeteer-core/-/puppeteer-core-23.6.0.tgz", + "integrity": "sha512-se1bhgUpR9C529SgHGr/eyT92mYyQPAhA2S9pGtGrVG2xob9qE6Pbp7TlqiSPlnnY1lINqhn6/67EwkdzOmKqQ==", "dev": true, "requires": { "@puppeteer/browsers": "2.4.0", "chromium-bidi": "0.8.0", "debug": "^4.3.7", - "devtools-protocol": "0.0.1342118", + "devtools-protocol": "0.0.1354347", "typed-query-selector": "^2.12.0", "ws": "^8.18.0" }, @@ -3819,9 +3819,9 @@ } }, "devtools-protocol": { - "version": "0.0.1342118", - "resolved": "https://registry.npmjs.org/devtools-protocol/-/devtools-protocol-0.0.1342118.tgz", - "integrity": "sha512-75fMas7PkYNDTmDyb6PRJCH7ILmHLp+BhrZGeMsa4bCh40DTxgCz2NRy5UDzII4C5KuD0oBMZ9vXKhEl6UD/3w==", + "version": "0.0.1354347", + "resolved": "https://registry.npmjs.org/devtools-protocol/-/devtools-protocol-0.0.1354347.tgz", + "integrity": "sha512-BlmkSqV0V84E2WnEnoPnwyix57rQxAM5SKJjf4TbYOCGLAWtz8CDH8RIaGOjPgPCXo2Mce3kxSY497OySidY3Q==", "dev": true } } diff --git a/build-system/tasks/visual-diff/package.json b/build-system/tasks/visual-diff/package.json index a7d2c15cb6b9..504847d47c50 100644 --- a/build-system/tasks/visual-diff/package.json +++ b/build-system/tasks/visual-diff/package.json @@ -9,6 +9,6 @@ "@percy/puppeteer": "2.0.2", "@percy/sdk-utils": "1.30.1", "@puppeteer/browsers": "2.4.0", - "puppeteer-core": "23.5.3" + "puppeteer-core": "23.6.0" } } From f0152a582034b66237be3d522e3c39f4a864ed1f Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Wed, 16 Oct 2024 14:01:56 -0400 Subject: [PATCH 04/12] =?UTF-8?q?=F0=9F=93=A6=20Update=20subpackage=20devD?= =?UTF-8?q?ependencies=20(#40185)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> --- .circleci/config.yml | 4 ++-- .github/workflows/codeql.yml | 4 ++-- .github/workflows/scorecard.yml | 4 ++-- third_party/amp-toolbox-cache-url/package.json | 2 +- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index f1ec7a6e5abe..3392feaae900 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -4,7 +4,7 @@ orbs: browser-tools: circleci/browser-tools@1.4.8 codecov: codecov/codecov@4.2.0 macos: circleci/macos@2.5.2 - node: circleci/node@6.1.0 + node: circleci/node@6.3.0 push_and_pr_builds: &push_and_pr_builds filters: @@ -65,7 +65,7 @@ executors: resource_class: xlarge jdk-docker-2xlarge: docker: - - image: cimg/openjdk:21.0.2-node + - image: cimg/openjdk:21.0.4-node resource_class: 2xlarge macos-medium: macos: diff --git a/.github/workflows/codeql.yml b/.github/workflows/codeql.yml index c3d58376efe0..09160f77f7d0 100644 --- a/.github/workflows/codeql.yml +++ b/.github/workflows/codeql.yml @@ -38,12 +38,12 @@ jobs: # Initializes the CodeQL tools for scanning. - name: Initialize CodeQL - uses: github/codeql-action/init@c36620d31ac7c881962c3d9dd939c40ec9434f2b # v3.26.12 + uses: github/codeql-action/init@f779452ac5af1c261dce0346a8f964149f49322b # v3.26.13 with: config-file: ./.github/codeql/config.yml languages: ${{ matrix.language }} - name: Perform CodeQL Analysis - uses: github/codeql-action/analyze@c36620d31ac7c881962c3d9dd939c40ec9434f2b # v3.26.12 + uses: github/codeql-action/analyze@f779452ac5af1c261dce0346a8f964149f49322b # v3.26.13 with: category: '/language:${{matrix.language}}' diff --git a/.github/workflows/scorecard.yml b/.github/workflows/scorecard.yml index 2ee7174d0e7c..81784684028b 100644 --- a/.github/workflows/scorecard.yml +++ b/.github/workflows/scorecard.yml @@ -64,7 +64,7 @@ jobs: # Upload the results as artifacts (optional). Commenting out will disable uploads of run results in SARIF # format to the repository Actions tab. - name: 'Upload artifact' - uses: actions/upload-artifact@604373da6381bf24206979c74d06a550515601b9 # v4.4.1 + uses: actions/upload-artifact@b4b15b8c7c6ac21ea08fcf65892d2ee8f75cf882 # v4.4.3 with: name: SARIF file path: results.sarif @@ -72,6 +72,6 @@ jobs: # Upload the results to GitHub's code scanning dashboard. - name: 'Upload to code-scanning' - uses: github/codeql-action/upload-sarif@c36620d31ac7c881962c3d9dd939c40ec9434f2b # v3.26.12 + uses: github/codeql-action/upload-sarif@f779452ac5af1c261dce0346a8f964149f49322b # v3.26.13 with: sarif_file: results.sarif diff --git a/third_party/amp-toolbox-cache-url/package.json b/third_party/amp-toolbox-cache-url/package.json index 3c75c21bff1f..a0bc280b3184 100644 --- a/third_party/amp-toolbox-cache-url/package.json +++ b/third_party/amp-toolbox-cache-url/package.json @@ -35,7 +35,7 @@ "@ampproject/rollup-plugin-closure-compiler": "0.27.0", "eslint": "9.12.0", "eslint-config-google": "0.14.0", - "jasmine": "5.3.1", + "jasmine": "5.4.0", "karma": "6.4.4", "karma-chrome-launcher": "3.2.0", "karma-jasmine": "5.1.0", From 67e989793338b53cdc37dffbde670496344806e2 Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Fri, 18 Oct 2024 00:24:27 +0000 Subject: [PATCH 05/12] =?UTF-8?q?=F0=9F=93=A6=20Update=20subpackage=20devD?= =?UTF-8?q?ependencies=20(#40188)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> --- .circleci/config.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 3392feaae900..d04e367fbc55 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -65,7 +65,7 @@ executors: resource_class: xlarge jdk-docker-2xlarge: docker: - - image: cimg/openjdk:21.0.4-node + - image: cimg/openjdk:21.0.5-node resource_class: 2xlarge macos-medium: macos: From a09bcf8a7bc091af41a1129b4bf4b8ec7b9c96a1 Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Fri, 18 Oct 2024 00:46:05 +0000 Subject: [PATCH 06/12] =?UTF-8?q?=F0=9F=93=A6=20Update=20dependency=20code?= =?UTF-8?q?cov=20to=20v5=20(#40189)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * 📦 Update dependency codecov to v5 * Forward fix codecov parameters in circleci config * Tag-along fix for cache saving config --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Daniel Rozenberg --- .circleci/config.yml | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index d04e367fbc55..982475dddac0 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -2,7 +2,7 @@ version: 2.1 orbs: browser-tools: circleci/browser-tools@1.4.8 - codecov: codecov/codecov@4.2.0 + codecov: codecov/codecov@5.0.0 macos: circleci/macos@2.5.2 node: circleci/node@6.3.0 @@ -156,7 +156,8 @@ commands: - save_cache: name: '💾 Save node_modules/ Cache' key: node-modules-cache-{{ arch }}-v3-{{ checksum "package-lock.json" }} - paths: node_modules/ + paths: + - node_modules/ teardown_vm: steps: - persist_to_workspace: @@ -335,7 +336,8 @@ jobs: name: '⭐⭐⭐ All Unit Tests ⭐⭐⭐' command: node build-system/pr-check/unit-tests.js - codecov/upload: - file: test/coverage/lcov-unit.info + disable_search: true + files: test/coverage/lcov-unit.info flags: unit_tests - store_test_output - store_filelist @@ -350,7 +352,8 @@ jobs: name: '⭐⭐⭐ Unminified Tests ⭐⭐⭐' command: node build-system/pr-check/unminified-tests.js - codecov/upload: - file: test/coverage/lcov-integration.info + disable_search: true + files: test/coverage/lcov-integration.info flags: integration_tests - store_test_output - teardown_vm From 8497fc6f6cf91e3f73524b53e4ac69e7cd0525b4 Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Sun, 20 Oct 2024 23:23:25 +0000 Subject: [PATCH 07/12] =?UTF-8?q?=F0=9F=93=A6=20Update=20subpackage=20devD?= =?UTF-8?q?ependencies=20(#40191)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> --- third_party/amp-toolbox-cache-url/package.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/third_party/amp-toolbox-cache-url/package.json b/third_party/amp-toolbox-cache-url/package.json index a0bc280b3184..3dc2cddac0ee 100644 --- a/third_party/amp-toolbox-cache-url/package.json +++ b/third_party/amp-toolbox-cache-url/package.json @@ -33,13 +33,13 @@ }, "devDependencies": { "@ampproject/rollup-plugin-closure-compiler": "0.27.0", - "eslint": "9.12.0", + "eslint": "9.13.0", "eslint-config-google": "0.14.0", "jasmine": "5.4.0", "karma": "6.4.4", "karma-chrome-launcher": "3.2.0", "karma-jasmine": "5.1.0", - "npm-run-all2": "6.2.3", + "npm-run-all2": "6.2.4", "rollup": "4.24.0", "rollup-plugin-commonjs": "10.1.0", "rollup-plugin-filesize": "10.0.0", From 1a945966cd2ccf5e03776c8be56455e4700a6951 Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Sun, 20 Oct 2024 23:24:13 +0000 Subject: [PATCH 08/12] =?UTF-8?q?=F0=9F=93=A6=20Update=20build-system=20de?= =?UTF-8?q?vDependencies=20to=20v8.3.6=20(#40190)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> --- .../tasks/storybook/package-lock.json | 74 +++++++++---------- build-system/tasks/storybook/package.json | 6 +- 2 files changed, 40 insertions(+), 40 deletions(-) diff --git a/build-system/tasks/storybook/package-lock.json b/build-system/tasks/storybook/package-lock.json index 7e78d3d3c15f..1807ce759ebc 100644 --- a/build-system/tasks/storybook/package-lock.json +++ b/build-system/tasks/storybook/package-lock.json @@ -10,9 +10,9 @@ "devDependencies": { "@babel/core": "7.25.8", "@babel/preset-react": "7.25.7", - "@storybook/addon-a11y": "8.3.5", - "@storybook/addon-controls": "8.3.5", - "@storybook/addon-viewport": "8.3.5", + "@storybook/addon-a11y": "8.3.6", + "@storybook/addon-controls": "8.3.6", + "@storybook/addon-viewport": "8.3.6", "babel-loader": "9.2.1" } }, @@ -910,13 +910,13 @@ } }, "node_modules/@storybook/addon-a11y": { - "version": "8.3.5", - "resolved": "https://registry.npmjs.org/@storybook/addon-a11y/-/addon-a11y-8.3.5.tgz", - "integrity": "sha512-/19UO8IXbyfcYK5K8ejSYF+hC+EK79c0bBPHMNeYSFOHSqQM3KoMo+TLIcLsuhuRClmlM+4Zs+VSIYDwc+d3ig==", + "version": "8.3.6", + "resolved": "https://registry.npmjs.org/@storybook/addon-a11y/-/addon-a11y-8.3.6.tgz", + "integrity": "sha512-EeVzUN+WaLtz/DXVBL3rIGvP8+pTuJXA3lEz9CbTQXRO7QMhzTTXLKmp8xmSA2w5H01a8XpjLcZ5LYjdKrvw0g==", "dev": true, "license": "MIT", "dependencies": { - "@storybook/addon-highlight": "8.3.5", + "@storybook/addon-highlight": "8.3.6", "axe-core": "^4.2.0" }, "funding": { @@ -924,13 +924,13 @@ "url": "https://opencollective.com/storybook" }, "peerDependencies": { - "storybook": "^8.3.5" + "storybook": "^8.3.6" } }, "node_modules/@storybook/addon-controls": { - "version": "8.3.5", - "resolved": "https://registry.npmjs.org/@storybook/addon-controls/-/addon-controls-8.3.5.tgz", - "integrity": "sha512-2eCVobUUvY1Rq7sp1U8Mx8t44VXwvi0E+hqyrsqOx5TTSC/FUQ+hNAX6GSYUcFIyQQ1ORpKNlUjAAdjxBv1ZHQ==", + "version": "8.3.6", + "resolved": "https://registry.npmjs.org/@storybook/addon-controls/-/addon-controls-8.3.6.tgz", + "integrity": "sha512-9IMLHgtWPuFoRCt3hDsIk1FbkK5SlCMDW1DDwtTBIeWYYZLvptS42+vGVTeQ8v5SejmVzZkzuUdzu3p4sb3IcA==", "dev": true, "license": "MIT", "dependencies": { @@ -944,13 +944,13 @@ "url": "https://opencollective.com/storybook" }, "peerDependencies": { - "storybook": "^8.3.5" + "storybook": "^8.3.6" } }, "node_modules/@storybook/addon-highlight": { - "version": "8.3.5", - "resolved": "https://registry.npmjs.org/@storybook/addon-highlight/-/addon-highlight-8.3.5.tgz", - "integrity": "sha512-ku0epul9aReCR3Gv/emwYnsqg3vgux5OmYMjoDcJC7s+LyfweSzLV/f5t9gSHazikJElh5TehtVkWbC4QfbGSw==", + "version": "8.3.6", + "resolved": "https://registry.npmjs.org/@storybook/addon-highlight/-/addon-highlight-8.3.6.tgz", + "integrity": "sha512-A7uU+1OPVXGpkklEUJjSl2VEEDLCSNvmffUJlvW1GjajsNFIHOW2CSD+KnfFlQyPxyVbnWAYLqUP4XJxoqrvDw==", "dev": true, "license": "MIT", "dependencies": { @@ -961,13 +961,13 @@ "url": "https://opencollective.com/storybook" }, "peerDependencies": { - "storybook": "^8.3.5" + "storybook": "^8.3.6" } }, "node_modules/@storybook/addon-viewport": { - "version": "8.3.5", - "resolved": "https://registry.npmjs.org/@storybook/addon-viewport/-/addon-viewport-8.3.5.tgz", - "integrity": "sha512-FSWydoPiVWFXEittG7O1YgvuaqoU9Vb+qoq9XfP/hvQHHMDcMZvC40JaV8AnJeTXaM7ngIjcn9XDEfGbFfOzXw==", + "version": "8.3.6", + "resolved": "https://registry.npmjs.org/@storybook/addon-viewport/-/addon-viewport-8.3.6.tgz", + "integrity": "sha512-bL51v837W1cng/+0pypkoLsWKWmvux96zLOzqLCpcWAQ4OSMhW3foIWpCiFwMG/KY+GanoOocTx6i7j5hLtuTA==", "dev": true, "license": "MIT", "dependencies": { @@ -978,13 +978,13 @@ "url": "https://opencollective.com/storybook" }, "peerDependencies": { - "storybook": "^8.3.5" + "storybook": "^8.3.6" } }, "node_modules/@storybook/core": { - "version": "8.3.5", - "resolved": "https://registry.npmjs.org/@storybook/core/-/core-8.3.5.tgz", - "integrity": "sha512-GOGfTvdioNa/n+Huwg4u/dsyYyBcM+gEcdxi3B7i5x4yJ3I912KoVshumQAOF2myKSRdI8h8aGWdx7nnjd0+5Q==", + "version": "8.3.6", + "resolved": "https://registry.npmjs.org/@storybook/core/-/core-8.3.6.tgz", + "integrity": "sha512-frwfgf0EJ7QL29DWZ5bla/g0eOOWqJGd14t+VUBlpP920zB6sdDfo7+p9JoCjD9u08lGeFDqbPNKayUk+0qDag==", "dev": true, "license": "MIT", "peer": true, @@ -1794,9 +1794,9 @@ "dev": true }, "node_modules/cookie": { - "version": "0.6.0", - "resolved": "https://registry.npmjs.org/cookie/-/cookie-0.6.0.tgz", - "integrity": "sha512-U71cyTamuh1CRNCfpGY6to28lxvNwPG4Guz/EVjgf3Jmzv0vlDp1atT9eS5dDjMYHucpHbWns6Lwf3BKz6svdw==", + "version": "0.7.1", + "resolved": "https://registry.npmjs.org/cookie/-/cookie-0.7.1.tgz", + "integrity": "sha512-6DnInpx7SJ2AK3+CTUE/ZM0vWTUboZCegxhC2xiIydHR9jNuTAASBrfEpHhiGOZw/nX51bHt6YQl8jsGo4y/0w==", "dev": true, "license": "MIT", "peer": true, @@ -2130,9 +2130,9 @@ } }, "node_modules/express": { - "version": "4.21.0", - "resolved": "https://registry.npmjs.org/express/-/express-4.21.0.tgz", - "integrity": "sha512-VqcNGcj/Id5ZT1LZ/cfihi3ttTn+NJmkli2eZADigjq29qTlWi/hAQ43t/VLPq8+UX06FCEx3ByOYet6ZFblng==", + "version": "4.21.1", + "resolved": "https://registry.npmjs.org/express/-/express-4.21.1.tgz", + "integrity": "sha512-YSFlK1Ee0/GC8QaO91tHcDxJiE/X4FbpAyQWkxAvG6AXCuR65YzK8ua6D9hvi/TzUfZMpc+BwuM1IPw8fmQBiQ==", "dev": true, "license": "MIT", "peer": true, @@ -2142,7 +2142,7 @@ "body-parser": "1.20.3", "content-disposition": "0.5.4", "content-type": "~1.0.4", - "cookie": "0.6.0", + "cookie": "0.7.1", "cookie-signature": "1.0.6", "debug": "2.6.9", "depd": "2.0.0", @@ -3411,14 +3411,14 @@ } }, "node_modules/storybook": { - "version": "8.3.5", - "resolved": "https://registry.npmjs.org/storybook/-/storybook-8.3.5.tgz", - "integrity": "sha512-hYQVtP2l+3kO8oKDn4fjXXQYxgTRsj/LaV6lUMJH0zt+OhVmDXKJLxmdUP4ieTm0T8wEbSYosFavgPcQZlxRfw==", + "version": "8.3.6", + "resolved": "https://registry.npmjs.org/storybook/-/storybook-8.3.6.tgz", + "integrity": "sha512-9GVbtej6ZzPRUM7KRQ7848506FfHrUiJGqPuIQdoSJd09EmuEoLjmLAgEOmrHBQKgGYMaM7Vh9GsTLim6vwZTQ==", "dev": true, "license": "MIT", "peer": true, "dependencies": { - "@storybook/core": "8.3.5" + "@storybook/core": "8.3.6" }, "bin": { "getstorybook": "bin/index.cjs", @@ -3565,9 +3565,9 @@ } }, "node_modules/tslib": { - "version": "2.7.0", - "resolved": "https://registry.npmjs.org/tslib/-/tslib-2.7.0.tgz", - "integrity": "sha512-gLXCKdN1/j47AiHiOkJN69hJmcbGTHI0ImLmbYLHykhgeN0jVGola9yVjFgzCUklsZQMW55o+dW7IXv3RCXDzA==", + "version": "2.8.0", + "resolved": "https://registry.npmjs.org/tslib/-/tslib-2.8.0.tgz", + "integrity": "sha512-jWVzBLplnCmoaTr13V9dYbiQ99wvZRd0vNWaDRg+aVYRcjDF3nDksxFDE/+fkXnKhpnUUkmx5pK/v8mCtLVqZA==", "dev": true, "license": "0BSD", "peer": true diff --git a/build-system/tasks/storybook/package.json b/build-system/tasks/storybook/package.json index 59ae5d1fd60d..34ddc40e3ff3 100644 --- a/build-system/tasks/storybook/package.json +++ b/build-system/tasks/storybook/package.json @@ -5,9 +5,9 @@ "devDependencies": { "@babel/core": "7.25.8", "@babel/preset-react": "7.25.7", - "@storybook/addon-a11y": "8.3.5", - "@storybook/addon-controls": "8.3.5", - "@storybook/addon-viewport": "8.3.5", + "@storybook/addon-a11y": "8.3.6", + "@storybook/addon-controls": "8.3.6", + "@storybook/addon-viewport": "8.3.6", "babel-loader": "9.2.1" } } From f58f7970756eb0b0f4c0281f278b71d9cd97ad07 Mon Sep 17 00:00:00 2001 From: Ya-Chen Hsieh <1697814+ychsieh@users.noreply.github.com> Date: Fri, 25 Oct 2024 11:06:10 +0800 Subject: [PATCH 09/12] =?UTF-8?q?=F0=9F=90=9B=20Fix=20amp-story-player=20p?= =?UTF-8?q?anel=20next/prev=20button=20in=20Chrome=20(#40124)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * Fix amp-story-player panel next/prev button in Chrome * Change ancestor selector to child selector --- css/amp-story-player-shadow.css | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/css/amp-story-player-shadow.css b/css/amp-story-player-shadow.css index a6062b93e964..847628622b00 100644 --- a/css/amp-story-player-shadow.css +++ b/css/amp-story-player-shadow.css @@ -128,8 +128,8 @@ .i-amphtml-story-player-full-bleed-story .i-amphtml-story-player-panel-prev, .i-amphtml-story-player-full-bleed-story .i-amphtml-story-player-panel-next, -:not(.i-amphtml-story-player-panel) .i-amphtml-story-player-panel-prev, -:not(.i-amphtml-story-player-panel) .i-amphtml-story-player-panel-next { +:not(.i-amphtml-story-player-panel) > .i-amphtml-story-player-panel-prev, +:not(.i-amphtml-story-player-panel) > .i-amphtml-story-player-panel-next { opacity: 0; pointer-events: none; } From beea88d125d2e40e8f137cf32ffdf16f74811827 Mon Sep 17 00:00:00 2001 From: Shihua Zheng Date: Tue, 29 Oct 2024 03:44:48 +0800 Subject: [PATCH 10/12] WIP Reenable flaky video test (#40175) --- test/integration/test-video-players-helper.js | 13 +++++-------- test/integration/test-video-players.js | 6 +++--- 2 files changed, 8 insertions(+), 11 deletions(-) diff --git a/test/integration/test-video-players-helper.js b/test/integration/test-video-players-helper.js index e31678359f51..ef1d8f24e5d8 100644 --- a/test/integration/test-video-players-helper.js +++ b/test/integration/test-video-players-helper.js @@ -179,8 +179,7 @@ export function runVideoPlayerIntegrationTests( }); }); - // TODO(#40115): fix this flaky test - it.skip('should trigger pause analytics when the video pauses', function () { + it('should trigger pause analytics when the video pauses', function () { let pauseButton; return getVideoPlayer({ @@ -202,8 +201,7 @@ export function runVideoPlayerIntegrationTests( }); }); - // TODO(#40115): fix this flaky test - it.skip('should trigger session analytics when a session ends', function () { + it('should trigger session analytics when a session ends', function () { let pauseButton; return getVideoPlayer({ @@ -381,8 +379,7 @@ export function runVideoPlayerIntegrationTests( this.timeout(timeout); describe('play/pause', () => { - // TODO(#40115): fix this flaky test - it.skip('should play when in view port initially', () => { + it('should play when in view port initially', () => { return getVideoPlayer({outsideView: false, autoplay: true}).then( (r) => { return listenOncePromise(r.video, VideoEvents_Enum.PLAYING); @@ -593,8 +590,8 @@ export function runVideoPlayerIntegrationTests( video.setAttribute('id', 'myVideo'); video.setAttribute('controls', ''); video.setAttribute('layout', 'fixed'); - video.setAttribute('width', '300px'); - video.setAttribute('height', '50vh'); + video.setAttribute('width', '300'); + video.setAttribute('height', '300'); video.style.position = 'absolute'; video.style.top = top; diff --git a/test/integration/test-video-players.js b/test/integration/test-video-players.js index af88ec44bbb4..9fd1a07f6f64 100644 --- a/test/integration/test-video-players.js +++ b/test/integration/test-video-players.js @@ -34,7 +34,8 @@ describes.sandboxed('amp-video-iframe', {}, (env) => { ); }); -describes.sandboxed('amp-youtube', {}, (env) => { +// TODO(#40181): Youtube tests not working on Circle. +describes.sandboxed.skip('amp-youtube', {}, (env) => { runVideoPlayerIntegrationTests( env, (fixture) => { @@ -60,8 +61,7 @@ describes.sandboxed('amp-dailymotion', {}, (env) => { ); }); -// TODO(#39857): Unskip when integration is fixed. -describes.sandboxed.skip('amp-3q-player', {}, (env) => { +describes.sandboxed('amp-3q-player', {}, (env) => { runVideoPlayerIntegrationTests( env, (fixture) => { From 34a72d81824f2c12f6b2791f1ec7e3e38e9f3f8d Mon Sep 17 00:00:00 2001 From: Shihua Zheng Date: Tue, 29 Oct 2024 10:41:48 -0700 Subject: [PATCH 11/12] Skip amp-dailymotion for video player tests (#40195) --- test/integration/test-video-players.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/test/integration/test-video-players.js b/test/integration/test-video-players.js index 9fd1a07f6f64..c93ba64b9a7e 100644 --- a/test/integration/test-video-players.js +++ b/test/integration/test-video-players.js @@ -48,7 +48,8 @@ describes.sandboxed.skip('amp-youtube', {}, (env) => { ); }); -describes.sandboxed('amp-dailymotion', {}, (env) => { +// TODO(#40181): amp-dailymotion tests not working on Circle. +describes.sandboxed.skip('amp-dailymotion', {}, (env) => { runVideoPlayerIntegrationTests( env, (fixture) => { From ac32751289d2b91ecb3d0757eb01f0c1fb84d851 Mon Sep 17 00:00:00 2001 From: Hugo Bacilli Date: Tue, 29 Oct 2024 18:20:02 -0300 Subject: [PATCH 12/12] =?UTF-8?q?=E2=9C=A8=20Add=20new=20analytics=20varia?= =?UTF-8?q?bles=20for=20Navegg=20vendor=20(#40194)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * feat(new variables): 🛠 Adds new analytics variables for Navegg vendor * feat(new variables): 🛠 Adjust optional variables validation * feat(new variables): 🛠 Fix navegg URL version parameter * feat(AMP new variables): 🛠 Ensure new variables value * feat(AMP new variables): 🛠 Test fix, params adjust --- ads/vendors/navegg.js | 9 ++++++++- ads/vendors/navegg.md | 2 +- extensions/amp-analytics/0.1/test/vendor-requests.json | 2 +- extensions/amp-analytics/0.1/vendors/navegg.json | 2 +- src/service/real-time-config/callout-vendors.js | 4 ++-- 5 files changed, 13 insertions(+), 6 deletions(-) diff --git a/ads/vendors/navegg.js b/ads/vendors/navegg.js index fc0936b917d4..cdcf54d82cdb 100644 --- a/ads/vendors/navegg.js +++ b/ads/vendors/navegg.js @@ -7,7 +7,11 @@ import {doubleclick} from '#ads/google/doubleclick'; * @param {!Object} data */ export function navegg(global, data) { - validateData(data, ['acc']); + const requiredParams = ['acc', 'wst', 'wct', 'wla']; + const optionalParams = []; + + validateData(data, requiredParams, optionalParams); + const {acc} = data; let seg, nvg = function () {}; @@ -17,6 +21,9 @@ export function navegg(global, data) { loadScript(global, 'https://tag.navdmp.com/amp.1.0.0.min.js', () => { nvg = global[`nvg${acc}`] = new global['AMPNavegg']({ acc, + wst: data.wst ? '1' : '0', + wct: data.wct ? '1' : '0', + wla: data.wla ? '1' : '0', }); nvg.getProfile((nvgTargeting) => { for (seg in nvgTargeting) { diff --git a/ads/vendors/navegg.md b/ads/vendors/navegg.md index ab60804481de..574764a7973f 100644 --- a/ads/vendors/navegg.md +++ b/ads/vendors/navegg.md @@ -18,4 +18,4 @@ To get Navegg integration working you only need to specify the `rtc-config` para The Navegg adapter only supports DoubleClick for now. For the most up-to-date list of DoubleClick supported parameters and usage, refer to the [DoubleClick reference guide](https://github.com/ampproject/amphtml/blob/main/ads/google/doubleclick.md). -For any help, please contact [Navegg](https://www.navegg.com/en/institutional/#contact). +For any help, please contact [Navegg](https://www.navegg.com/en/about-us/contacts). diff --git a/extensions/amp-analytics/0.1/test/vendor-requests.json b/extensions/amp-analytics/0.1/test/vendor-requests.json index 03e2fbf822d6..bea5067e24b6 100644 --- a/extensions/amp-analytics/0.1/test/vendor-requests.json +++ b/extensions/amp-analytics/0.1/test/vendor-requests.json @@ -344,7 +344,7 @@ "onvisible": "https://!beacon_url?h.d=!h.d&h.key=!h.key&h.t=!h.t&h.cr=!h.cr&rt.start=navigation&rt.si=_client_id(amp_mpulse)_&rt.ss=_timestamp_&rt.end=_timestamp_&t_resp=_nav_timing(navigationStart%2CresponseStart)_&t_page=_nav_timing(responseStart%2CloadEventStart)_&t_done=_nav_timing(navigationStart%2CloadEventStart)_&nt_nav_type=_nav_type_&nt_red_cnt=_nav_redirect_count_&nt_nav_st=_nav_timing(navigationStart)_&nt_red_st=_nav_timing(redirectStart)_&nt_red_end=_nav_timing(redirectEnd)_&nt_fet_st=_nav_timing(fetchStart)_&nt_dns_st=_nav_timing(domainLookupStart)_&nt_dns_end=_nav_timing(domainLookupEnd)_&nt_con_st=_nav_timing(connectStart)_&nt_ssl_st=_nav_timing(secureConnectionStart)_&nt_con_end=_nav_timing(connectEnd)_&nt_req_st=_nav_timing(requestStart)_&nt_res_st=_nav_timing(responseStart)_&nt_unload_st=_nav_timing(unloadEventStart)_&nt_unload_end=_nav_timing(unloadEventEnd)_&nt_domloading=_nav_timing(domLoading)_&nt_res_end=_nav_timing(responseEnd)_&nt_domint=_nav_timing(domInteractive)_&nt_domcontloaded_st=_nav_timing(domContentLoadedEventStart)_&nt_domcontloaded_end=_nav_timing(domContentLoadedEventEnd)_&nt_domcomp=_nav_timing(domComplete)_&nt_load_st=_nav_timing(loadEventStart)_&nt_load_end=_nav_timing(loadEventEnd)_&v=1&http.initiator=amp&u=_source_url_&.u=_ampdoc_url_&r2=_document_referrer_&scr.xy=_screen_width_x_screen_height_" }, "navegg": { - "pageview": "https://amp.navdmp.com/amp?aid=_client_id(navegg_id)_&url=_canonical_url_&ref=_document_referrer_&tit=_title_&lan=_browser_language_&acc=!account&v=7" + "pageview": "https://amp.navdmp.com/amp?aid=_client_id(navegg_id)_&url=_canonical_url_&ref=_document_referrer_&tit=_title_&lan=_browser_language_&acc=!account&wst=!wst&wct=!wct&wla=!wla&v=7" }, "neodata": { "base": "https://tra.neodatagroup.com", diff --git a/extensions/amp-analytics/0.1/vendors/navegg.json b/extensions/amp-analytics/0.1/vendors/navegg.json index 77e733cafe12..01298e59a812 100644 --- a/extensions/amp-analytics/0.1/vendors/navegg.json +++ b/extensions/amp-analytics/0.1/vendors/navegg.json @@ -1,6 +1,6 @@ { "requests": { - "pageview": "https://amp.navdmp.com/amp?aid=${clientId(navegg_id)}&url=${canonicalUrl}&ref=${documentReferrer}&tit=${title}&lan=${browserLanguage}&acc=${account}&v=7" + "pageview": "https://amp.navdmp.com/amp?aid=${clientId(navegg_id)}&url=${canonicalUrl}&ref=${documentReferrer}&tit=${title}&lan=${browserLanguage}&acc=${account}&wst=${wst}&wct=${wct}&wla=${wla}&v=7" }, "triggers": { "trackpageview": { diff --git a/src/service/real-time-config/callout-vendors.js b/src/service/real-time-config/callout-vendors.js index da209a02d05a..afc56e19baaf 100644 --- a/src/service/real-time-config/callout-vendors.js +++ b/src/service/real-time-config/callout-vendors.js @@ -147,8 +147,8 @@ const RTC_VENDORS = jsonConfiguration({ disableKeyAppend: true, }, navegg: { - url: 'https://usr.navdmp.com/usr?acc=NVG_ACC&wst=0&v=10', - macros: ['NVG_ACC'], + url: 'https://usr.navdmp.com/usr?acc=NVG_ACC&wst=WST&wct=WCT&wla=WLA&v=10', + macros: ['NVG_ACC', 'WST', 'WCT', 'WLA'], disableKeyAppend: true, }, newspassid: {