Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[linter] Runtime preload should only be required if boilerplate is still present #1255

Open
schlessera opened this issue Jul 14, 2021 · 1 comment

Comments

@schlessera
Copy link
Collaborator

schlessera commented Jul 14, 2021

In #1248, we've skipped adding the AMP runtime preload(s) when the boilerplate had already been removed.

However, the linter still requires the runtime preload to be present unconditionally in https://github.com/ampproject/amp-toolbox/blob/main/packages/linter/src/rules/RuntimeIsPreloaded.ts.

The linter should also check for the presence of the boilerplate and only require the runtime preload if the boilerplate is still present.

@westonruter
Copy link
Member

This issue keeps getting reported by users. We should update Pixi sooner rather than later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants