Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete outdated comment when a PR update removes all notify owners #999

Open
3 tasks
rcebulko opened this issue Oct 8, 2020 · 0 comments
Open
3 tasks

Delete outdated comment when a PR update removes all notify owners #999

rcebulko opened this issue Oct 8, 2020 · 0 comments
Labels
Category: Owners P3: When Possible Type: Feature Request

Comments

@rcebulko
Copy link
Contributor

rcebulko commented Oct 8, 2020

Context: ampproject/amphtml#30230 (comment)
Requires:

  • Add deleteComment to owners/src/api/github.js#GitHub
  • Add logic within owners/src/notifier.js#createNotificationComment to delete the existing comment if the notification set is empty
  • Improve logic for identifying Owners Bot comment vs. other bot comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Category: Owners P3: When Possible Type: Feature Request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rcebulko