Fix url if WebDav path containing not escaped characters #35

ffoxin · 2015-03-23T11:12:03Z

It is necessary to escape WebDav path before requesting it.

Server path can contain some charaters that should be escaped in url (i.e. space character).

hashbackup · 2018-01-19T21:17:05Z

I believe two other spots need this:

@@ -83,7 +84,7 @@
             port = 443 if protocol == 'https' else 80
         self.baseurl = '{0}://{1}:{2}'.format(protocol, host, port)
         if path:
-            self.baseurl = '{0}/{1}'.format(self.baseurl, path)
+            self.baseurl = '{0}/{1}'.format(self.baseurl, quote(path))
         self.cwd = '/'
         self.session = requests.session()
         self.session.verify = verify_ssl
@@ -114,10 +115,10 @@
         return response
 
     def _get_url(self, path):
-        path = str(path).strip()
+        path = quote(str(path).strip())
         if path.startswith('/'):
             return self.baseurl + path
-        return "".join((self.baseurl, self.cwd, path))
+        return "".join((self.baseurl, quote(self.cwd), path))

Fix url if WebDav path containing not escaped characters

d8051d0

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix url if WebDav path containing not escaped characters #35

Fix url if WebDav path containing not escaped characters #35

ffoxin commented Mar 23, 2015

hashbackup commented Jan 19, 2018

Fix url if WebDav path containing not escaped characters #35

Are you sure you want to change the base?

Fix url if WebDav path containing not escaped characters #35

Conversation

ffoxin commented Mar 23, 2015

hashbackup commented Jan 19, 2018