5.24 Damage Over Time Kills Don't Give XP

[aszecsei]

Because damage effects created by a DOT status condition don't include a creator, if the player uses the effect to kill a monster they don't gain any XP from the kill.

I was able to fix it with a little bit of difficulty (all thanks to a bug in specs):

In components.rs:

#[derive(Component, Debug, ConvertSaveload, Clone)]
pub struct DamageOverTime {
    pub damage: i32,
    pub creator: EntityOption<Entity>,
}

This requires the entity-container workaround at amethyst/specs#681 (comment) to store an optional entity.

In rawmaster.rs:

"damage_over_time" => $eb = $eb.with(DamageOverTime {
    damage: effect.1.parse::<i32>().unwrap(),
    creator: None.into(),
}),

Then, in effects/damage.rs, pass along the effect creator (converting to an EntityOption):

.with(DamageOverTime { damage: *damage, creator: effect.creator.into() })

And finally, in ai/initiative_system.rs, pass the status effect creator back into the effect system:

add_effect(
    dot.creator.into(),
    EffectType::Damage { amount: dot.damage },
    Targets::Single {
        target: status.target,
    },
);