Skip to content
This repository has been archived by the owner on Jun 7, 2022. It is now read-only.

Refactor systems with using SystemData #10

Open
vladbat00 opened this issue Oct 12, 2019 · 0 comments
Open

Refactor systems with using SystemData #10

vladbat00 opened this issue Oct 12, 2019 · 0 comments
Labels
good first issue Good for newcomers

Comments

@vladbat00
Copy link
Member

vladbat00 commented Oct 12, 2019

There are some systems that are good candidates for introducing a separate SystemData struct for them: such systems require a lot of resources and pass them around their helper functions (making those functions' argument list really huge).

Some examples of bad systems:
bins/client/src/ecs/systems/input.rs
bins/client/src/ecs/systems/client_network.rs

Some examples of good systems:
libs/game/src/ecs/systems/monster/spawner.rs

Note that you shouldn't refactor all the systems in one pull request. As it's a "good first issue", just look through the systems and pick the one which you think will be feasible for you to tackle. But nothing stops you to make more than one PR, of course. :)

@vladbat00 vladbat00 added the good first issue Good for newcomers label Oct 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant