[ament_cmake_uncrustify] Add ament_cmake_uncrustify_LANGUAGE variable #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This standardizes the interface to manually specify the language for linters such as cppcheck and uncrustify, such that the necessary CMake code can look like: ```diff diff --git a/CMakeLists.txt b/CMakeLists.txt index f6a8bb3..f71e803 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -19,7 +19,7 @@ if(BUILD_TESTING) set(ament_cmake_cppcheck_LANGUAGE c++) - set(ament_cmake_uncrustify_ADDITIONAL_ARGS "--language c++") + set(ament_cmake_uncrustify_LANGUAGE c++) endif() ``` Signed-off-by: Abrar Rahman Protyasha <[email protected]>
aprotyas
force-pushed
the
add_ament_cmake_uncrustify_language_variable
branch
from
f2e276e to
682fe64
Compare
mjeronimo
approved these changes
Jun 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In drafting a feature PR for #343, I noticed that the linter hook for
uncrustify is quite bare-bones. As such, providing arguments (such as
the linter language) is cumbersome in comparison to other linters, like
cppcheck.
This is especially pronounced when used in conjuction with
ament_lint_auto, because if users are linting C++ code, they will have
to use the interface exposed at the hook to override uncrustify's
language.
This PR standardizes the interface to manually specify the language for
linters such as cppcheck and uncrustify, such that the necessary CMake
code can look like:
Signed-off-by: Abrar Rahman Protyasha [email protected]