Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Way to share Topic with specific part & details tab selected #608

Open
keyserj opened this issue Dec 16, 2024 · 0 comments
Open

Way to share Topic with specific part & details tab selected #608

keyserj opened this issue Dec 16, 2024 · 0 comments
Labels
collaboration helps people work together convenient makes the tool easier to use enhancement New feature or request

Comments

@keyserj
Copy link
Collaborator

keyserj commented Dec 16, 2024

Describe your issue

E.g. I want to show someone the Questions on a specific part.

#298 added tabs to details, but it didn't seem to make sense to add the selected tab to the saved View because if you're already viewing a Topic, it doesn't seem like you'd care to have a specific tab selected after clicking a Quick View.

Also context: before 1d11b73, ?selected={partId} was tracked in the URL, but this was moved to be saved on the View, motivated by wanting to add all filter info to the URL and realizing that it's too much and should just be in the View. This has turned out to be annoying when using the "navigate back" button because usually I want to go to the previous filters, not the previously-selected node.

Solution you'd like

Maybe:

  • add ?selected={partId}:{tab} back into URL for sharing
  • move "navigate back" button within the Details/Views pane
    • "Details" back would go to previously-selected part
    • "Views" back would go to previously-selected filter

Questions:

  • where to put the "navigate back" button within the Details/Views pane?
    • maybe pane-specific toolbar...?
      • but would be awkward to align with "close pane" because close is pane-level, back is pane-type-level

Alternatives you've considered

No response

Additional context

No response

Technical ideas and questions

No response

@keyserj keyserj added enhancement New feature or request collaboration helps people work together convenient makes the tool easier to use labels Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
collaboration helps people work together convenient makes the tool easier to use enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

1 participant