Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Score button flickers when hovered #561

Open
keyserj opened this issue Nov 5, 2024 · 0 comments
Open

Score button flickers when hovered #561

keyserj opened this issue Nov 5, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@keyserj
Copy link
Collaborator

keyserj commented Nov 5, 2024

Describe the bug

It happens quickly but if you drag the time the video instead of playing it, it's easier to see:

chrome_2024-11-05_13-58-38.mp4

To Reproduce

No response

Expected behavior

No response

Additional context

No response

Technical ideas

This happens because the score selector is portaled to the front, so a second, duplicate button is actually rendered in the portal.

  • maybe we could get away without rendering the duplicate button but I'm not sure if it forfeits too much value of being able to see the currently-selected value
    • maybe the selector could color the selected value differently, rather than showing the duplicate button
  • the first score button should probably not have a hover color change, since the selector shows up in front immediately after hover
@keyserj keyserj added the bug Something isn't working label Nov 5, 2024
@keyserj keyserj added this to the update #5 milestone Nov 5, 2024
@keyserj keyserj modified the milestones: update #5, update #6 Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Development

No branches or pull requests

1 participant