Skip to content
This repository has been archived by the owner on Sep 20, 2021. It is now read-only.

Replace verbose context field with function #34

Open
pjones opened this issue Aug 26, 2020 · 3 comments
Open

Replace verbose context field with function #34

pjones opened this issue Aug 26, 2020 · 3 comments

Comments

@pjones
Copy link

pjones commented Aug 26, 2020

Would you be open to these two changes:

  1. Use MonadIO instead of IO, and

  2. Replace the verbose context field with a function (String -> m ())

These changes would allow integration with existing logging frameworks so migration messages don't go to stdout when logs are going somewhere else.

If these changes sound acceptible I'd be happy to supply a PR.

@ameingast
Copy link
Owner

Yes, if it's possible to keep the current public API stable. That means no destructive signature changes to existing public functions or data-types - only extensions.

@unclechu
Copy link

Implemented #35 in order to solve this.

@unclechu
Copy link

unclechu commented Oct 1, 2020

@ameingast I closed #35 in favor of #36. Please review.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants