Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libm_special.h is invalid if WINDOWS or WIN64 is defined #5

Open
tannergooding opened this issue Apr 18, 2021 · 1 comment
Open

libm_special.h is invalid if WINDOWS or WIN64 is defined #5

tannergooding opened this issue Apr 18, 2021 · 1 comment

Comments

@tannergooding
Copy link

libm_special.h is currently invalid if WINDOWS or WIN64 is defined since the _AMDLIBM_CODE enum is inside the else path, this causes _AMDLIBM_EXTERNAL to error because __amd_dppd is undefined.

The fix is to move the enum to the shared code path.
@tannergooding
Copy link
Author

Happy to provide a fix here, if one is welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tannergooding