Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amd_hsmp: add module compatibility with old linux kernels #3 #4 #6

Closed
wants to merge 2 commits into from
Closed

amd_hsmp: add module compatibility with old linux kernels #3 #4 #6

wants to merge 2 commits into from

Conversation

vysocky
Copy link

@vysocky vysocky commented Aug 10, 2022

Solves the issue #3 and #4 as @nchatrad suggested.

Copy link
Collaborator

@nchatrad nchatrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HSMP interface is not documented for model 17h. hence this change cannot be approved

@nchatrad nchatrad closed this Sep 28, 2022
Copy link
Collaborator

@nchatrad nchatrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of #ifdef on copy_struct_from_user
I would have done this in an old school method. Based on a kernel version where the copy_struct_from_user() is supported.
Will spin a patch to this effect. However, i would suggest using the upstreamed amd_hsmp instead of using this out-of-tree module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants