Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: setting and timeline interface redesign to work with new notification feature #567

Closed
wants to merge 5 commits into from

Conversation

vickywane
Copy link
Contributor

@vickywane vickywane commented Feb 22, 2021

This closes this

This PR contains work done on implementing the new notification for premium ambianic subscribers.
This PR is an active WIP and a follow-up to this PR

@commit-lint
Copy link
Contributor

commit-lint bot commented Feb 22, 2021

Update

  • implemented new design for connected devices (a551566)
  • made styling responsive to different resolutions (8640c30)
  • updated files (821302d)

Contributors

vickywane

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@vickywane vickywane changed the title Notification feature feat: Notification feature Feb 22, 2021
@vickywane vickywane changed the title feat: Notification feature feat: notification feature Feb 22, 2021
@vickywane vickywane self-assigned this Feb 22, 2021
Copy link
Contributor

@ivelin ivelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vickywane as discussed, please rename the title of this PR to something more adequate.

Also match the description to the new PR template.

And finally, please make sure the CI runs 100% on your fork including the new login and subscription UI tests. Include in the PR description instructions about CI environment variables that need to be added to the main CI in order for it to also pass 100% with all tests.

@ivelin ivelin marked this pull request as draft February 25, 2021 15:15
@vickywane
Copy link
Contributor Author

@ivelin I would be suspending this PR till the notification feature has been released and is in active use. This PR contains UI updates within the Timeline and Settings component to work with the new edge-pwa authentication

@vickywane vickywane changed the title feat: notification feature feat: setting and timeline interface redesign to work with new notification feature Mar 30, 2021
@ivelin ivelin closed this Dec 9, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: implement premium subscription management
2 participants