Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OCB] Copy+Update CWAgent's awsapplicationsignals into the processor/ directory #247

Merged
merged 7 commits into from
Nov 7, 2024

Conversation

jj22ee
Copy link

@jj22ee jj22ee commented Oct 30, 2024

Description:

This PR is to create the initial baseline commit of the Application Signals Processor that future commits will modify in order to properly make this processor an externally usable Go module

This PR does 2 things

  1. Copy the following directory with 0 changes into the processor directory - https://github.com/aws/amazon-cloudwatch-agent/tree/main/plugins/processors/awsapplicationsignals
  2. Rename copied directory from awsapplicationsignals to awsapplicationsignalsprocessor

Link to tracking Issue:

Testing:

N/A. As this PR is just a direct copy + rename of the appsignals processor, nothing is expected to work.

Documentation:

Copy link
Collaborator

@mxiamxia mxiamxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved PR as we're just copying the code over.

@jj22ee jj22ee changed the title [OCB] Copy CWAgent's awsapplicationsignals into the processor/ directory [OCB] Copy+Update CWAgent's awsapplicationsignals into the processor/ directory Nov 1, 2024
…on-existent dependencies, update go.mod and run go mod tidy
@jj22ee
Copy link
Author

jj22ee commented Nov 1, 2024

The first 2 commits are for the direct copy of the Application Signals Processor.

In the 3rd commit, additional changes are made:

  1. Update all imports of github.com/aws/amazon-cloudwatch-agent/plugins/processors/awsapplicationsignals to github.com/amazon-contributing/opentelemetry-collector-contrib/processor/awsapplicationsignalsprocessor
  2. Add Makefile
  3. Add processor/awsapplicationsignalsprocessor/go.mod and go.sum
  4. Copy over ecsutil.go from CWAgent
    • Remove dependency on github.com/aws/amazon-cloudwatch-agent/translator/config by copying the config.RUN_IN_CONTAINER and config.RUN_IN_CONTAINER_TRUE values
  5. Copy over httpclient.go from CWAgent
  6. Update processor/awsapplicationsignalsprocessor/internal/normalizer/attributesnormalizer.go
    • Change attribute value of common.MetricAttributeTelemetryAgent from "CWAgent/%s", version.Number() to opentelemetry-collector/%s", GetCollectorVersion().
    • Add processor/awsapplicationsignalsprocessor/internal/normalizer/version_info.go to get the Collector Version via GetCollectorVersion()
  7. Remove eksdetector dependency in processor/awsapplicationsignalsprocessor/internal/resolver/kubernetes_test.go

@jj22ee
Copy link
Author

jj22ee commented Nov 7, 2024

The check-links workflow is failing due to new markdown-link-check version. It is unrelated to this PR.
It was fixed in upstream via open-telemetry#36231

@mxiamxia mxiamxia merged commit 113eee2 into amazon-contributing:aws-ocb-dev Nov 7, 2024
141 of 146 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants