From 2bd84460310c73c2c300014d5c53d9395838d86e Mon Sep 17 00:00:00 2001 From: Rick Rossi Date: Tue, 7 Jan 2025 14:30:07 -0500 Subject: [PATCH] Address findings from initial code review --- internal/aws/containerinsight/utils_test.go | 1 + internal/aws/proxy/server.go | 1 - receiver/awscontainerinsightskueuereceiver/receiver.go | 2 +- 3 files changed, 2 insertions(+), 2 deletions(-) diff --git a/internal/aws/containerinsight/utils_test.go b/internal/aws/containerinsight/utils_test.go index cfb5ff82c93d..b32616927446 100644 --- a/internal/aws/containerinsight/utils_test.go +++ b/internal/aws/containerinsight/utils_test.go @@ -96,6 +96,7 @@ func TestIsContainer(t *testing.T) { assert.True(t, IsContainer(TypeContainerEFA)) assert.True(t, IsContainer(TypeContainerGPU)) assert.True(t, IsContainer(TypeContainerFS)) + assert.False(t, IsContainer(TypePod)) } func TestIsPod(t *testing.T) { diff --git a/internal/aws/proxy/server.go b/internal/aws/proxy/server.go index 3553961083d8..451046dc6112 100644 --- a/internal/aws/proxy/server.go +++ b/internal/aws/proxy/server.go @@ -40,7 +40,6 @@ type Server interface { func NewServer(cfg *Config, logger *zap.Logger) (Server, error) { _, err := net.ResolveTCPAddr("tcp", cfg.Endpoint) if err != nil { - fmt.Printf("aeraesra") return nil, err } if cfg.ProxyAddress != "" { diff --git a/receiver/awscontainerinsightskueuereceiver/receiver.go b/receiver/awscontainerinsightskueuereceiver/receiver.go index 12c42dc5f3d4..7995ff06e6b3 100644 --- a/receiver/awscontainerinsightskueuereceiver/receiver.go +++ b/receiver/awscontainerinsightskueuereceiver/receiver.go @@ -17,7 +17,7 @@ import ( "k8s.io/client-go/rest" ci "github.com/open-telemetry/opentelemetry-collector-contrib/internal/aws/containerinsight" - kueuescraper "github.com/open-telemetry/opentelemetry-collector-contrib/receiver/awscontainerinsightskueuereceiver/internal/kueuescraper" + "github.com/open-telemetry/opentelemetry-collector-contrib/receiver/awscontainerinsightskueuereceiver/internal/kueuescraper" ) var _ receiver.Metrics = (*awsContainerInsightKueueReceiver)(nil)