-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move aws js sdk as a seperate dependency. #2
Comments
We will look into changing this, thanks for the input! At the time of release, the version of the AWS SDK with the Connect Chat APIs was unreleased, so we baked that version into Chatjs. |
Does the latest AWS SDK now comes with Connect Chat APIs? |
Yes, it does. You can find more information here - https://docs.aws.amazon.com/AWSJavaScriptSDK/latest/AWS/ConnectParticipant.html |
Since the connect chat APIs are now available in AWS SDKs since June 2020, can the custom bundled dependency be removed? |
ChatJS currently uses AWS SDK JavaScript v2.1459.0 [ref] Team is not currently planning to make any changes to the baked-in SD. It needs to stay compatible with the Amazon Connect Streams library. For this issue, I have drafted the required changes (https://github.com/amazon-connect/amazon-connect-chatjs/pull/200/files), but this needs additional testing to ensure it's compatible (w/ streams and other implementation) |
File -
src/client/aws-client.js
contains custom bundled sdk contents, if we need to include other dependencies like Lex, including the full sdk conflicts with the contents inside the src/client/aws-client.js. It's hard to debug what are included when custom bundled.Is it possible to move
amazon-connect-chat.js
and aws-sdk as two seperate dependencies ?Including like below Overrides the AWS global contents, Which leads to
AWS.LexRuntime is not a constructor error
. Had to remove all the contents insidesrc/client/aws-client.js
and rebuilt theamazon-connect-chat.js
to make it work.The text was updated successfully, but these errors were encountered: