Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue start server only resources result in client crash #2370

Open
1 task done
BluePeer opened this issue Nov 21, 2024 · 0 comments
Open
1 task done

issue start server only resources result in client crash #2370

BluePeer opened this issue Nov 21, 2024 · 0 comments
Labels
Class: bug Something isn't working

Comments

@BluePeer
Copy link

BluePeer commented Nov 21, 2024

Description of the problem

if you start a serverside only resource js/c#/....
resource.toml like

main = 'dist/server.js'
type = 'js'

without the client definition

client-files = [ 'dist/*' ]
client-main = 'dist/client.js'
client-type = 'js'

the server Boots up without relay this resource to client, but on "commandline/script" start command, the resource get emitted a Start request to client.

what result in for example CDN configuration in a name.resource download of a html 404 content that crashs the client

Reproduction steps

create a server only resource

main = 'dist/server.js'
type = 'js'

and write "start name" inside the server console

Expected behaviour

like in old days
not emit a start event for the resource to the client on script/console resource start request

add a check for client before loading resource files, if that resource file contains a valid resource or a html 404

Additional context

No response

Operating system

windows/linux

Version

latest+5

Crashdump ID

No response

Confirmation of issue's presence

  • By submitting this ticket, I affirm that I have verified the presence of this issue on the latest RC (Release Candidate) version available at the time of writing this ticket.
@BluePeer BluePeer added the Class: bug Something isn't working label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant