Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logs have no standardize network endianess format #2

Open
jkilpatr opened this issue Feb 7, 2019 · 0 comments
Open

Logs have no standardize network endianess format #2

jkilpatr opened this issue Feb 7, 2019 · 0 comments
Labels
bug Something isn't working

Comments

@jkilpatr
Copy link
Member

jkilpatr commented Feb 7, 2019

Logs from BitEndian targets will be viewed as corrupt by LittleEndian decoders and vice versa. There's no standardized endianness in the serialization process.

This is further confused by the fact that we're sending over a vector of u8's so whatever issue we're having has more to do with the internals of lz4, does it write in 64 bit words? if so we may need to flip at that level, if it does also handle bytes we're looking at a more insidious internal representation issue.

@jkilpatr jkilpatr added the bug Something isn't working label Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant