Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve V2 workflow and make backwards compatible #7

Open
thehomebrewnerd opened this issue Mar 14, 2022 · 0 comments
Open

Improve V2 workflow and make backwards compatible #7

thehomebrewnerd opened this issue Mar 14, 2022 · 0 comments

Comments

@thehomebrewnerd
Copy link
Contributor

V2 of the workflow changed the way that the library version number is obtained in build.sh. This change means that V2 of the workflow will not work on repos that are not set up to use pyproject.toml and setup.cfg files. V2 also assumes that a file names <libname>/version.py will be present, and this script will fail if the version number is stored elsewhere.

We should update this action to implement a better, more robust method for obtaining the version number, and also make it backward compatible, if possible, to work on repos that still utilize setup.py.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant