Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jitpack.io usage info to Readme #3

Open
hamen opened this issue Jun 17, 2015 · 7 comments
Open

Add Jitpack.io usage info to Readme #3

hamen opened this issue Jun 17, 2015 · 7 comments

Comments

@hamen
Copy link
Member

hamen commented Jun 17, 2015

No description provided.

@mrsasha
Copy link
Member

mrsasha commented Jun 17, 2015

what would be the point of that? we already use github releases.

@hamen
Copy link
Member Author

hamen commented Jun 17, 2015

People that are already using Jitpack.io won't need to add a new Gradle repo.

@mrsasha
Copy link
Member

mrsasha commented Jun 17, 2015

I don't understand, jitpack already uses github releases, in any case you just put
compile 'com.alterego:advancedandroidlogger:1.0.3@aar' and it works.

@hamen
Copy link
Member Author

hamen commented Jun 17, 2015

According to the current README, you need to add:

repositories {
    maven { url "https://github.com/alter-ego/advanced-android-logger/raw/develop/releases/" }
}
dependencies {
    compile 'com.alterego:advancedandroidlogger:1.0.3@aar'
}

Using git tags for the releases and Jitpack, we could reduce it to

repositories {
    maven { url "https://jitpack.io" }
}

dependencies {
       compile 'com.github.alter-ego:advanced-android-logger:1.0.3'
}

If you are already using Jitpack for other libraries, you just need one line:

compile 'com.github.alter-ego:advanced-android-logger:1.0.3'

We could distribute it in both ways and let the user pick the preferred one.

@mrsasha
Copy link
Member

mrsasha commented Jun 17, 2015

yes, but there's no need to change anything in the project because jitpack already uses github releases. we just need to update the readme.

@hamen
Copy link
Member Author

hamen commented Jun 17, 2015

That's the whole point.

@mrsasha mrsasha changed the title Distribute with Jitpack.io Add Jitpack.io usage info to Readme Jun 17, 2015
@mrsasha
Copy link
Member

mrsasha commented Jun 17, 2015

Renamed the issue then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants