Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split region mask and nan mask #21

Open
claudius-kienle opened this issue Feb 25, 2022 · 1 comment
Open

split region mask and nan mask #21

claudius-kienle opened this issue Feb 25, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@claudius-kienle
Copy link
Member

Due to the new masking algorithmus,
the nan and region mask fall together to one mask.
This is because of the region mask that is computed by identifying where nans are in filtered point clouds.

The solution would be the following:
Compute the filtered pcds as before but compare the resulting images with the original ones.
If the pixel was already a nan before filtering, it is not because of the filterung but because of the not raw, calibrated images containing this nan value.
Those pixels should not be False in the region mask as they are already in the nan mask.

@claudius-kienle claudius-kienle added the enhancement New feature or request label Feb 25, 2022
@claudius-kienle
Copy link
Member Author

This actually is hardly possible, I don't think the proposed solution would work correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant