moving risk_data function to a new file and tests for Escribir_Datos_Osiris #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ris to a new file to avoid circular import between risk_data file and subida.py
natilou
force-pushed
the
refactor-datos-riesgos
branch
from
88e347f to
65ea761
Compare
…file and changing time for datetime
natilou
force-pushed
the
refactor-datos-riesgos
branch
from
65ea761 to
719e18d
Compare
natilou
changed the title
matiasbertani
approved these changes
Apr 14, 2023
|
Nice PR. I'm thinking out loud. And we could add some things that I see here to the backlog as new tasks ( I didn't comment to make the changes here because these were badly coded by me)
Again, I don't want you to change anything, I only point these things to be documented to add the task |
Yes, I only copy and paste the code in other file. I didn't change any logic. Maybe I renamed some variables to english, but not the logic |
matiasbertani
added a commit
that referenced
this pull request
Apr 15, 2023
changing the import to from, make error running the app because date was used from the namespace datetime, y change the import and the annotation werent't wrapped with simple commas `'` so python interpretates this as we are trying to index a list class objetct
matiasbertani
added a commit
that referenced
this pull request
Apr 15, 2023
Fix: datetime.date and annotation from PR #8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
risk_datafunction and its helper function to a new fileEscribir_Datos_Osiristo a new file to avoid circular import betweenrisk_data.pyandsubida.pytest_get_phone_numbers.pytotest_risk_data.pyEscribir_Datos_Osiris()timefordatetimelibrary, because when I use thefreezegunto test the time the file is created, there was an error with this library using time (issue from freezgun repo).Dockerfile:file_directory="Subida Osiris", if the script doesn't find this variable, uses the default value "Subida Osiris" --> this is archive with:os.getenv("file_directory", "Subida Osiris")ipdb,pytestdependencies in Pipfile to[dev-packages]and addingfreezegunto itDocumentation:
freezegun --> FreezeGun is a library that allows your Python tests to travel through time by mocking the datetime module.
tempfile.TemporaryDirectory --> This class securely creates a temporary directory. I used it to create a folder and test
Escribir_Datos_Osiris, otherwise raises an Exception if there is no folder created.