-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search gives up on small strings #67
Comments
An update: I wanted to try to debug this myself, but to my great surprise the issue disappeared when I tried to use the That is, now, even when I type a single letter, UPD: I'm still experiencing it sometimes. I don't yet understand what's happening. It seems that some other module may break the behaviour. I suggest not to close it until I debug it or at least find a stable way to avoid it. |
Another update: the issue is more complicated than I thought it was... What I know:
From now on, I don't have any ideas how to debug it... for now at least. Why deleting a line could affect this? Very weird. Another thing is that even if I remove the If this is a |
Hi, Thanks for your patience. I overlooked this issue until I saw the one you filed on org-ql. It's hard to say what's causing this, but it's probably in Helm rather than in this package. I've occasionally seen similar issues, but they seem rare, and since it's hard to reproduce, I'm not very concerned about it, to be honest. I hope you understand. :) Something that might help would be to increase the minimum input size. Searching for only one or two characters in a large file, returning many thousands of results, is not generally going to be very useful, anyway. If you do want to dig into it further, you'll have to dig into Helm, and you'll have to be specific about versions and such. However, IME it's hard to debug this kind of issue, because, e.g. if you use Edebug to step through instrumented code, the problem tends to disappear. And the pseudo-asynchronous way that Helm handles results from Emacs functions like the ones in org-rifle and org-ql (rather than external processes) makes the code flow harder to follow. Since it's not clear that this is a bug in this package, and there's likely not a lot that we can do about it, I'm going to leave this open as a discussion. And I'll copy this comment on the org-ql issue. Let me know if you have more findings. Thanks. |
This seems to be fixed automatically in Emacs 28.1? |
Please be more specific. |
I upgraded emacs (from 27 to 28.1) and the issue disappeared. Now |
Hi!
I experience the following weird behaviour: sometimes, when I'm typing small words (I've figured out
helm-org-rifle
only works with words of length >2 (or is it for occur only?)) the search behaves as if it times out. Sometimes it's possible to revive/restart it, sometimes not. It seems to happen mostly with I'm typing in russian, which is weird... maybegrep
ping unicode is more time consuming? If I use search for some time, the problem seems to partially disappear, which makes me think again there's some caching going on which speeds up search.Anyway, here's what happens without my unnecessary hypotheses; for example:
helm-org-rifle
and type e.g. "math".Also:
helm-org-rifle-occur
; it sometimes waits for about 3-4 secs on my short words, but gives me output. It seems that the words that this bug occurs on take quite a lot time inhelm-org-rifle-occur
.helm-org-ql-agenda-files
. But it seems to work slightly better: sometimes when I runql
instead ofrifle
on the same string it succeeds. Butql
also fails on some strings similarly.TLDR: sometimes I type something and don't get any results. When I re-type it, or add and remove letters, sometimes, it begins to work.
The text was updated successfully, but these errors were encountered: