Embark support #369
Merged
Embark support #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 8, 2023
Closed
oantolin
force-pushed
the
embark-support
branch
from
040e6ec to
ba9b2cf
Compare
minad
reviewed
Sep 14, 2023
This is all that is needed to gain support for Embark actions on org-ql-find candidates.
alphapapa
force-pushed
the
embark-support
branch
from
ba9b2cf to
a41dfe2
Compare
|
Thanks, Omar! |
|
Thanks for merging! I'm looking forward to removing the Marginalia configuration from my init.el. 😛 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for embark actions on
org-ql-findcandidates. It only does two things: (1) add a category metadatum oforg-remote-headingto the collection used inorg-ql-completing-read, (2) define a function that refiles to a completion candidate and, if embark is ever loaded, binds it toRinembark-org-heading-map.I put those two in separate commits in case you only want the first one.