Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm-org-ql-map #99

Closed
akirak opened this issue Mar 1, 2020 · 2 comments
Closed

helm-org-ql-map #99

akirak opened this issue Mar 1, 2020 · 2 comments

Comments

@akirak
Copy link
Contributor

akirak commented Mar 1, 2020

At present, helm-org-ql-map is defined as follows:

(defvar helm-org-ql-map
  (let ((map (copy-keymap helm-map))
        (mappings '(
                    "C-x C-s" helm-org-ql-save
                    )))
    (cl-loop for (key fn) on mappings by #'cddr
             do (define-key map (kbd key) fn))
    map)
  "Keymap for `helm-org-ql' sessions.
Based on `helm-map'.")

I suppose the correct way to inherit a keymap is to use make-composed-keymap. While I was investigating #97, I noticed that additional keybindings added to helm-map were not effective in helm-org-ql-map. Hopefully this will solve the issue.

@alphapapa
Copy link
Owner

Thanks, Akira, I wasn't even aware of that function. Please let me know if this fixes it.

@akirak
Copy link
Contributor Author

akirak commented Mar 7, 2020

Thanks, the issue has been fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants