let org-ql-view-refresh respect custom buffer name

[whudwl]

OS/platform

any

Emacs version and provenance

not relevant

Org version and provenance

not relevant

org-ql package version and provenance

any

Description

Say I have done a search with the code below, notice that I've named the buffer habit

(org-ql-search '("~/org/habit.org") '(property "STYLE" "habit") :buffer "habit")

Now if I press r in the habit buffer, the buffer gets named to *Org QL View: (property STYLE habit)*.
If I rerun the code above, and press r again, the buffer gets named to *Org QL View: (property STYLE habit)*<1>.

I think it's preferable to let org-ql-view-refresh use the buffer name I've chosen.

Etc.

No response

[alphapapa]

BTW, note that there's already a habit predicate, so you needn't use the property predicate to find them.

Anyway, how would you suggest that we know whether the user wants to keep a buffer's name or change it to match the new search?

I'd generally suggest that you assign the search a title and access it with, e.g. saved views, bookmarks, or links, rather than manually evaluating that expression.

[whudwl]

That makes a lot of sense, I'll use or-ql-view instead for my pre-defined searches.

Out of curiosity, in which case is the following part in org-ql-view-refresh useful? It seems I can just remove it without causing any issues.

(rename-buffer (format "%s %s*"
                           org-ql-view-buffer-name-prefix
                           (or org-ql-view-title org-ql-view-query))
                   ;; Avoid any errors in case a buffer by this name already exists.
                   'unique)

[alphapapa]

Out of curiosity, in which case is the following part in org-ql-view-refresh useful?

I don't understand what you mean.

[whudwl]

I mean the call to rename-buffer seems to be unnecessary. another way to ask the question is, why call rename-buffer at all?

[alphapapa]

I think the code should make that clear: if the view's title or query changes, the buffer's name changes to match.

[whudwl]

I see. Thank you!