From d28d54c58842f0d31e40e8d21337360c9c238ba0 Mon Sep 17 00:00:00 2001 From: Adam Porter Date: Fri, 3 Jan 2020 05:40:06 -0600 Subject: [PATCH] Comment: Add/remove TODOs --- helm-org-ql.el | 12 ------------ org-ql.el | 1 + 2 files changed, 1 insertion(+), 12 deletions(-) diff --git a/helm-org-ql.el b/helm-org-ql.el index 821ea621..9e231a94 100644 --- a/helm-org-ql.el +++ b/helm-org-ql.el @@ -195,18 +195,6 @@ Is transformed into this query: (setq helm-org-ql-buffers-files buffers-files)) (ignore-errors ;; Ignore errors that might be caused by partially typed queries. - - ;; FIXME: This doesn't prevent warnings that are errors occurring during - ;; byte-compilation due to partially typed values which can't be correctly - ;; pre-processed, e.g. "ts:to=2019-01-0", which can't be parsed into a - ;; timestamp. A "*Compile-Log*" buffer is displayed with "Error: Wrong type - ;; argument: integerp, nil". With my Helm settings, it's hidden as soon as - ;; the query is typed correctly, so it's tolerable, but I'd prefer to fix it. - ;; I haven't found a way to ignore the error/warning; `with-no-warnings' has - ;; no effect, and we're already using `ignore-errors'. The only solution I - ;; can think of would be to ignore the errors/warnings higher up the chain - ;; where byte-compilation is actually done, but it might not be a good idea - ;; to always ignore such errors/warnings. (org-ql-select buffers-files query :action `(helm-org-ql--heading ,window-width)))))) :match #'identity diff --git a/org-ql.el b/org-ql.el index 9d471322..3f6a3ebf 100644 --- a/org-ql.el +++ b/org-ql.el @@ -442,6 +442,7 @@ Returns cons (INHERITED-TAGS . LOCAL-TAGS)." ;; TODO: Use --value-at for tags cache. (defun org-ql--value-at (position fn) + ;; TODO: Either rename to `value-at-point' and remove `position' arg, or move point. "Return FN's value at POSITION in current buffer. Values compared with `equal'." ;; I'd like to use `-if-let*', but it doesn't leave non-nil variables