From d9afc5214e3a95350c5bc21f5cdff4d7e59b0ad9 Mon Sep 17 00:00:00 2001 From: Joel Chippindale Date: Wed, 28 Sep 2022 07:06:04 +0100 Subject: [PATCH 1/2] Switch to esm.sh source for handlebars package Because dev.jspm.io has issues and installs are erroring ``` error: Import 'https://dev.jspm.io/npm:source-map@0.6?dew' failed: 500 Internal Server Error at https://dev.jspm.io/npm:handlebars@4.7.6/dist/cjs/handlebars/compiler/code-gen.dew.js:2:41 ``` --- mod.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mod.ts b/mod.ts index 0e4bed7..7952cd6 100644 --- a/mod.ts +++ b/mod.ts @@ -1,4 +1,4 @@ -import HandlebarsJS from "https://dev.jspm.io/handlebars@4.7.6"; +import HandlebarsJS from "https://esm.sh/handlebars@4.7.6"; import { walk } from "https://deno.land/std@0.110.0/fs/mod.ts"; import { globToRegExp, From 603fa502ebd55a0155586f9db5b1d910090a9612 Mon Sep 17 00:00:00 2001 From: Joel Chippindale Date: Tue, 4 Oct 2022 12:04:00 +0100 Subject: [PATCH 2/2] Upgrade deno to v1.24.0 to be compatible with esm.sh's handlebars Earlier versions of deno report the following error when running the tests ``` Check file:///home/runner/work/handlebars/handlebars/tests/basic.test.ts error: TS2322 [ERROR]: Type 'AliasName' is not assignable to type 'string | number | symbol'. Type 'K | (string extends A[K] ? K : A[K] extends string ? K | A[K] : K)' is not assignable to type 'string | number | symbol'. Type 'string extends A[K] ? K : A[K] extends string ? K | A[K] : K' is not assignable to type 'string | number | symbol'. ... ``` --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 18c8f09..f01236f 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -7,7 +7,7 @@ jobs: runs-on: ubuntu-18.04 strategy: matrix: - deno: [1.18.1] + deno: [1.24.0] name: Deno ${{ matrix.deno }} steps: - uses: actions/checkout@master