Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QUESTION] Why is the function getDeviceList removed? #20

Open
theyosh opened this issue Jan 29, 2024 · 2 comments
Open

[QUESTION] Why is the function getDeviceList removed? #20

theyosh opened this issue Jan 29, 2024 · 2 comments

Comments

@theyosh
Copy link

theyosh commented Jan 29, 2024

Is there a reason why the function getDeviceList is removed? I think it could be handy to have to auto detect TAPO P100 devices.
@almottier
Copy link
Owner

Hello, can you do a PR ?

@theyosh
Copy link
Author

theyosh commented Jan 31, 2024

Sorry, but I do not own this hardware. So it is hard for me to test anything. I added this library to my own code and it has been tested by a random person that have this hardware. So I know the implementation in my software is working. But I cannot test it myself.

But in commit 4d71a05#diff-12eb291d6a2e795c3021fd487b6d912e1b13e0913113a4c74b65c72f29faf3afL32 the code for auto discovery has been removed.

So I was wondering why it was removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@almottier @theyosh