You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The use case is to accommodate the needs of different organizations, which follow different holiday schedules.
I would imagine the configs go like this:
custom_holidays:
- name: test
region: us
organization: A
schedule:
- date: "2019-12-17"
description: "Some day this year only"
Other than the mandatory schedule field, the others are free-form key-value pairs (containing at least 1 pair), which translate to the labels of the is_holiday metric. Perhaps we can make name mandatory as well.
@allangood Do you think this is can be something we add?
The text was updated successfully, but these errors were encountered:
mapshen
changed the title
support for multiple sets of custom holiday
support for multiple sets of custom holidays
Oct 13, 2020
first of all, thank you for you interest in this code and for your help! :)
Yes, this is totally possible. I didn't make any field other than the date mandatory, to make things simple/easy.
I still don't know if making the name mandatory is really important. Could you help me to understand better your request to make it mandatory?
The use case is to accommodate the needs of different organizations, which follow different holiday schedules.
I would imagine the configs go like this:
Other than the mandatory
schedule
field, the others are free-form key-value pairs (containing at least 1 pair), which translate to the labels of theis_holiday
metric. Perhaps we can makename
mandatory as well.@allangood Do you think this is can be something we add?
The text was updated successfully, but these errors were encountered: