Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for multiple sets of custom holidays #7

Open
mapshen opened this issue Oct 13, 2020 · 2 comments
Open

support for multiple sets of custom holidays #7

mapshen opened this issue Oct 13, 2020 · 2 comments

Comments

@mapshen
Copy link

mapshen commented Oct 13, 2020

The use case is to accommodate the needs of different organizations, which follow different holiday schedules.

I would imagine the configs go like this:

custom_holidays:
  - name: test
    region: us
    organization: A
    schedule:
    - date: "2019-12-17"
      description: "Some day this year only"

Other than the mandatory schedule field, the others are free-form key-value pairs (containing at least 1 pair), which translate to the labels of the is_holiday metric. Perhaps we can make name mandatory as well.

@allangood Do you think this is can be something we add?

@mapshen mapshen changed the title support for multiple sets of custom holiday support for multiple sets of custom holidays Oct 13, 2020
@allangood
Copy link
Owner

Hi @mapshen,

first of all, thank you for you interest in this code and for your help! :)

Yes, this is totally possible. I didn't make any field other than the date mandatory, to make things simple/easy.
I still don't know if making the name mandatory is really important. Could you help me to understand better your request to make it mandatory?

Regards.

@mapshen
Copy link
Author

mapshen commented Oct 13, 2020

It doesn't have to be but there should be a key-value pair at least (in addition to schedule) so that we can tell different is_holiday metrics apart.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants