-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Smp1 16 #15
Open
javiercavalero
wants to merge
33
commits into
main
Choose a base branch
from
SMP1-16
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Smp1 16 #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaiCaiIney
requested changes
Nov 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- El id 2 para el rol ADMIN es válido solamente en la base de datos local. Lo correcto es recuperar el rol ADMIN y comparar los id o validar que el id recibido corresponde al rol ADMIN, pero no tenes que hardcodear el id porque es el dato dinámico del rol (lo constante es el nombre ADMIN)
- Está bien el middleware pero no lo estás utilizando (no declarás su uso en el enrutamiento)
MaiCaiIney
requested changes
Nov 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- En endpoint GET /accounts/:user_id debe estar autenticado, pero en el enrutamiento le quitaste el middleware auth:api
- Resolver conflictos
en vez de comparar con un 2 el role_id del usuario buscamos en la tabla roles el registro con ese id y validamos que el campo name de ese registro sea admin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket {#SMP1-16}
RESUME
HOW HAS THIS BEEN TESTED?
Please describe the tests that you ran to verify your changes. Provide instructions so we can
reproduce. Please also list any relevant details for your test configuration.