Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe the finally callback should be removed #54

Open
Filyus opened this issue Jun 19, 2021 · 0 comments
Open

Maybe the finally callback should be removed #54

Filyus opened this issue Jun 19, 2021 · 0 comments

Comments

@Filyus
Copy link

Filyus commented Jun 19, 2021

At first glance, it is nice that you can use Promise.All and similar stuff, but this creates many independent threads that need to be processed. All you want after calling cancellation is to stop everything as possible and also stop the creation of new things like promises. I really advise you to remove this callback to avoid complicating the application logic and possible mistakes. At least write a warning in the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants