Remove toolchain --install/--uninstall/--install-dir

[mosteo]

Fixes #1612

[Fabien-Chouteau]

So I worked on the same thing in parallel 🤦‍♂️

In my commit I renamed alr toolchain to alr default-toolchain because I think it will remove some confusion on how Alire handles toolchains.

[Fabien-Chouteau]

Why not alr install --prefix here?

[mosteo]

Just because it is the closest to what the test was doing. We could add a new test that checks a similar idea but with alr install.

[Fabien-Chouteau]

alr toolchain --install was introduced for people that wanted to get a toolchain from the Alire index but not use it in the Alire context.

I feel like alr install is a better option for this use case.

[mosteo]

Sure, I'll adapt the test.

[Fabien-Chouteau]

Same as below, why not recommend alr install --prefix here?

[mosteo]

Again, because for people that was using --install-dir, this is what they would find more similar. But if we want people to just use alr install, we can omit alr get altogether.

[mosteo]

So I worked on the same thing in parallel 🤦‍♂️

:-(

In my commit I renamed alr toolchain to alr default-toolchain because I think it will remove some confusion on how Alire handles toolchains.

This will break a lot of workflows/actions out there, ours included... Do you think there's that much risk of confusion, given the --select?

[Fabien-Chouteau]

In my commit I renamed alr toolchain to alr default-toolchain because I think it will remove some confusion on how Alire handles toolchains.

This will break a lot of workflows/actions out there, ours included...

That's why we are doing a major release ^^

Do you think there's that much risk of confusion, given the --select?

I think we do see misconceptions from time to time.

Which makes me thing we could also take this opportunity to rename alr config into alr settings (see #1607 ).

[mosteo]

In my commit I renamed alr toolchain to alr default-toolchain because I think it will remove some confusion on how Alire handles toolchains.

This will break a lot of workflows/actions out there, ours included...

That's why we are doing a major release ^^

I feel this is a point where I must resist, and not so much for the brokenness but because I find default-toolchain unnecessarily long, a bit ugly, and itself a bit misleading as for example when several are installed, the output shows both default and non-default toolchains:

$ alr toolchain
CRATE         VERSION       STATUS    NOTES                                     
gnat_native   11.2.4        Available                                           
gnat_native   12.2.1        Available                                           
gnat_native   13.2.1        Default

I'd be less objecting to alr toolchain --select-default or even alr toolchain --set-default.

But I have no more arguments so if you're truly convinced this will be a net gain, I won't object further.

Which makes me thing we could also take this opportunity to rename alr config into alr settings (see #1607 ).

Sounds good, I saw the exchange with Maxim.

I'm a bit uneasy about introducing such breaking changes so late in the RC period, in particular if we dont have a 2nd RC (which I didn't plan to have). What do you think of having the old name as an undocumented alias that emits a warning pointing to the new command?

[mosteo]

The last push completes the removal. Any command renamings I would do in a separate PR.

[Fabien-Chouteau]

@mosteo I started working on the alr settings modification.