Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"un-git" the releases deployed from git repos #1455

Closed
Fabien-Chouteau opened this issue Sep 15, 2023 · 5 comments · Fixed by #1463
Closed

"un-git" the releases deployed from git repos #1455

Fabien-Chouteau opened this issue Sep 15, 2023 · 5 comments · Fixed by #1463

Comments

@Fabien-Chouteau
Copy link
Member

What I mean here is to not have releases deployed from git as valid git checkouts.

This idea starts with a discussion with a user that was confused by Alire's behavior. This person wanted to use alr get as a way to checkout a repository to work on it, and was surprised by the fact that alire.toml was modified (see why here: #1385 (comment)).

For me the disconnect is in the expectation that alr get gives when the source of the release is a git repo. Indeed you get a git checkout, but it's a release not a development branch.

What I want to suggest here is to change this behavior and not have releases as valid git checkout. The only way I found to do this is to remove the .git folder after git clone .

@mgrojo
Copy link
Contributor

mgrojo commented Sep 17, 2023

If you're definitely implementing this, I suggest running git clone with the argument --depth 1, otherwise the clone will download all the history, only to be deleted later, wasting time and bandwidth.

@Fabien-Chouteau
Copy link
Member Author

If you're definitely implementing this, I suggest running git clone with the argument --depth 1, otherwise the clone will download all the history, only to be deleted later, wasting time and bandwidth.

Indeed, in fact we can probably start by doing --depth 1 already.

@rocher
Copy link
Contributor

rocher commented Sep 19, 2023 via email

@Fabien-Chouteau
Copy link
Member Author

Also, please consider a "git restore alire.toml" after a fresh clone to avoid seeing this file as modified.

The file is modified for a good reason. see here: #1385 (comment)

@rocher
Copy link
Contributor

rocher commented Sep 20, 2023 via email

@mosteo mosteo linked a pull request Sep 22, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants