Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] if语句中的condition恒为true (SameObjEquals) #89

Open
waooog opened this issue Apr 16, 2017 · 0 comments
Open

[bug] if语句中的condition恒为true (SameObjEquals) #89

waooog opened this issue Apr 16, 2017 · 0 comments

Comments

@waooog
Copy link

waooog commented Apr 16, 2017

我们的自动化缺陷检测工具扫描 mdrill的源代码,发现了一个严重的bug:

路径:adhoc-internal/src/main/java/org/jfree/ui/SerialDateChooserPanel.java

代码片段:

protected Color getButtonColor(final SerialDate targetDate) {
...
        if (this.date.equals(this.date)) {
            return this.dateButtonColor;
      }
...
}

上述代码片段中的if语句的condition一直是true, 建议修改为:

  if (targetDate.equals(this.date)) {
            return this.dateButtonColor;
      }
waooog pushed a commit to waooog/mdrill that referenced this issue Apr 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant