Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency: Bump indexer dependency to v3.4.0 #161

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

gmalouf
Copy link
Contributor

@gmalouf gmalouf commented Jan 2, 2024

Summary

Bump indexer dependency to v3.4.0 (essentially the same as RC1 save for a read side patch).

Test Plan

Existing Tests Pass.

Copy link

codecov bot commented Jan 2, 2024

Codecov Report

Attention: 202 lines in your changes are missing coverage. Please review.

Comparison is base (442791a) 67.66% compared to head (5ead957) 72.78%.
Report is 67 commits behind head on master.

Files Patch % Lines
conduit/pipeline/pipeline.go 83.37% 51 Missing and 20 partials ⚠️
pkg/cli/cli.go 69.64% 29 Missing and 5 partials ⚠️
conduit/plugins/importers/algod/algod_importer.go 88.98% 21 Missing and 4 partials ⚠️
...lugins/exporters/postgresql/postgresql_exporter.go 57.44% 19 Missing and 1 partial ⚠️
conduit/data/config.go 76.47% 11 Missing and 5 partials ⚠️
...duit/plugins/exporters/filewriter/file_exporter.go 52.94% 5 Missing and 3 partials ⚠️
conduit/plugins/exporters/filewriter/util.go 87.93% 7 Missing ⚠️
conduit/telemetry/telemetry.go 86.27% 5 Missing and 2 partials ⚠️
conduit/plugins/importers/filereader/filereader.go 77.77% 4 Missing and 2 partials ⚠️
conduit/plugins/importers/noop/noop_importer.go 80.76% 4 Missing and 1 partial ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #161      +/-   ##
==========================================
+ Coverage   67.66%   72.78%   +5.12%     
==========================================
  Files          32       38       +6     
  Lines        1976     2789     +813     
==========================================
+ Hits         1337     2030     +693     
- Misses        570      649      +79     
- Partials       69      110      +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmalouf gmalouf requested a review from onetechnical January 2, 2024 18:02
@gmalouf gmalouf marked this pull request as ready for review January 2, 2024 18:02
@gmalouf gmalouf merged commit ec0d35a into algorand:master Jan 2, 2024
4 checks passed
@gmalouf gmalouf deleted the indexer-version-bump branch January 2, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants