Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle sigint sigterm #660

Open
bodinsamuel opened this issue Jul 12, 2021 · 2 comments
Open

Handle sigint sigterm #660

bodinsamuel opened this issue Jul 12, 2021 · 2 comments

Comments

@bodinsamuel
Copy link
Contributor

We should support graceful shutdown

@Haroenv
Copy link
Collaborator

Haroenv commented Jul 13, 2021

Instead of process.exit starting back from the start you mean? Not relying on the process restarting itself?

@bodinsamuel
Copy link
Contributor Author

it's mostly for gcp, when a server is terminating you have a grace period to shutdown your process.
if you don't, after 30s, the process is killed and you might have been in the middle of processing something that could corrupt your data.
In our scenario we could have processed a package but not saved it, not critical.

It also helps terminating the process faster than waiting the full grace period

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants