Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Shelly Plus 1 Mini #88

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sw-koenig
Copy link

@sw-koenig sw-koenig commented Oct 2, 2023

Resolves #87

Dependency
As the model IDs for the devices are defined in node-shellies-ng, the following Pull-Request must be merged first:
alexryd/node-shellies-ng#7

Shelly has released "mini" versions for some of their new generation products. They basically have the same functions as the normal ones, but using different model IDs.

Change has been tested successfull in my local setup with the homebridge-shelly-ng plugin.
Best regards,
Swen

@lukyer
Copy link

lukyer commented Oct 28, 2023

Great job! Waiting for this to get my new Minis in homebridge. @alexryd would you find some time to merge this and deploy new version of shelly-ng? 🙏

@djcargo
Copy link

djcargo commented Oct 31, 2023

I will be also very happy to get Minis support :)

@jakubkasparek
Copy link

great! how to install still fork?

@holetse
Copy link

holetse commented Dec 2, 2023

Hmm, I am encountering an issue with this PR.

Specifically, the upstream changes to node-shellies-ng seems to have been made off of this commit (HEAD of main at fork time), and thus contains this commit which came after the 1.5.1 release. The change to DeviceDiscoverer is not compatible with homebridge-shelly-ng, giving a bunch of typescript errors around the change from an abstract class to an interface, e.g.:

src/platform.ts:39:45 - error TS2689: Cannot extend an interface 'DeviceDiscoverer'. Did you mean 'implements'?
export class ConfigDeviceDiscoverer extends DeviceDiscoverer {

It seems like this PR needs to address that change to the DeviceDiscoverer, or node-shellies-ng additions need to be made off of this commit.

@sw-koenig Thoughts?

@sw-koenig
Copy link
Author

Hi @holetse,
you're probably right. I'm not an expert for Typescript and thus did not looked into this in detail. I could only test the changes in my local homebridge setup, by directly modifying the .js files, which perfectly works for me. I couldn't managed to build the projects locally and use the local builds in homebridge. So maybe, there are additional changes needed, to be compatible with that change to DeviceDiscover in node-shellies-ng.

Best regards,
Swen

@jtowe1
Copy link

jtowe1 commented Mar 1, 2024

Yeah it looks like there are commits in node-shellies-ng to main after the v1.5.1 release (here https://github.com/alexryd/node-shellies-ng/releases/tag/v1.5.1 it says 6 commits to main since this release) and homebridge-shelly-ng uses v1.5.1. Seems like maybe a new release of node-shellies-ng needs to be cut and then a new version of homebridge-shelly-ng needs to be made using the updated node-shellies-ng.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[new device] Shelly Plus 1 Mini
7 participants