Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'pulp browserify --optimise > index.js' couldn't find react-dom #36

Open
mchaver opened this issue Aug 1, 2017 · 2 comments
Open

'pulp browserify --optimise > index.js' couldn't find react-dom #36

mchaver opened this issue Aug 1, 2017 · 2 comments

Comments

@mchaver
Copy link

mchaver commented Aug 1, 2017

I suppose this is because it is using preact? Is there a work around?

* Browserifying project in /Users/mchaver/documents/pux-starter-app
* Building project in /Users/mchaver/documents/pux-starter-app
* Build successful.
* Browserifying...
events.js:160
      throw er; // Unhandled 'error' event
      ^

Error: Cannot find module 'react-dom' from
@mchaver mchaver changed the title pulp browserify --optimise > index.js couldn't find react-dom 'pulp browserify --optimise > index.js' couldn't find react-dom Aug 1, 2017
@alexmingoia
Copy link
Owner

I'm pretty sure this is because you don't have react-dom installed. If you don't want to use preact/preact-compat then you need to have react/react-dom installed.

@khanage
Copy link

khanage commented Dec 2, 2017

I also hit this when trying to work out how to deploy the starter app. Is there a recommended way to deploy this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants