Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Album art doesn't work — nor has it in months #46

Open
Mushnamukk opened this issue Dec 17, 2017 · 5 comments
Open

Album art doesn't work — nor has it in months #46

Mushnamukk opened this issue Dec 17, 2017 · 5 comments

Comments

@Mushnamukk
Copy link

Regardless of the platform (I've tried the website, the mobile website, the Android app, Win7, Win8.1, and Win10, tried an iPad, switched routers, disabled all extensions and ad-blockers) but STILL the problem persists! I have a blank square for each and every album. Thank you come again roger that.

@Mte90
Copy link

Mte90 commented Mar 26, 2019

problem still persist

@Mushnamukk
Copy link
Author

Mushnamukk commented Mar 27, 2019

To anyone that has this same issue: PLEASE COMMENT! Getting bugs requires some attention from the community!

Screenshot included below.

no_album_art

@Mte90
Copy link

Mte90 commented Mar 27, 2019

The image file is generated but is empty :-)

@Mushnamukk
Copy link
Author

Interesting; only noticed that after you pointed it out. They are 120x120 white, blank squares titled "cover" as opposed to an empty space.

@alexvinall
Copy link

alexvinall commented Sep 19, 2019

Currently I see album artwork for some albums but not others:

image

Perhaps this is an issue where after a certain point this stopped working, but historic artwork was still generated correctly and so can still be viewed.

The reason you get a blank white square is that static/cover.jpg is returned if there is no album artwork.

Muspy attempts to fetch the covers from Last.fm using the MusicBrainz ID in daemon/jobs.py:

def _fetch_cover(mbid, url):
    
    ...

    # Sometimes we get just a one-pixel image, avoid resizing it.
    if len(image) < 4096:
        logging.warning('[ERR] Bad image, skipping')
        return False

    logging.info('[JOB] Saving the cover')
    try:
        im = Image.open(StringIO.StringIO(image))
        im = im.resize((120, 120), Image.ANTIALIAS)
        f = StringIO.StringIO()
        im.save(f, 'JPEG', quality=95)
        image = f.getvalue()
        Cover(mbid, image)
        return True
    except:
        logging.warning('[ERR] Could not save the cover, skipping')
        return False

Looks like there a couple of ways this can fail - I wonder if Last.fm has changed their cover API and returns images that are too small.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants