added notification ability fixes #9 #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hate to bump this but any eta on this or comments? |
…th notification since it is optional // added basic test
|
@AdriVanHoudt Can you add |
|
I can look into it, |
|
Yes! It's needed to wake up an iOS app if a notification arrives. Thank you very much! |
|
I can only do this by end of the week btw, just a heads up ;) |
|
That's absolutely fine :) |
|
Hello, it would be nice to see this being merged. It is simple enough that it should not be an issue @alexjlockwood would your like a PR with |
|
@pauldub wow completely lost track of this, will add this back on my todo list! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #9 according to https://developers.google.com/cloud-messaging/concept-options#notifications_and_data_messages
I added the option at the end to make it non breaking (I hope, never done Go before ^^)
Let me know if this needs any changing otherwise would it be possible to merge since we need it asap.