-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Glyphs taller than font.ascent are clipped #143
Comments
Looking at this font in gimp, it seems to "fix" the layout on the fly using the render bounds. That's not something glyph-brush-layout can do so easily as we calculate all glyph positions without outlining the glyphs. cooper-hewitt-book-gimp.mp4This does also suggest that using line_gap as top-padding isn't correct 😞 |
A workaround is to give the sections with this font some extra margin at the top. However, depending on the |
alexheretic/ab-glyph#50 font CooperHewitt-Book.otf glyphs clip outside of font ascender/descender vbounds. This means the top line (for default layout) glyphs may clip too.
This can be fixed by using the font
line_gap
as top-padding for the first line, essentially shifting down the glyphs of all fonts with non-zeroline_gap
values.I'm unsure if this is the "correct" thing to do though. It's possible the font itself is wrong instead?
The text was updated successfully, but these errors were encountered: