Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Right alignment for row numbers #141

Open
briandconnelly opened this issue Jul 22, 2022 · 11 comments
Open

Right alignment for row numbers #141

briandconnelly opened this issue Jul 22, 2022 · 11 comments
Labels
enhancement New feature or request

Comments

@briandconnelly
Copy link

Right alignment of row numbers might make it easier for users to quickly scan the output

TV:
image

R Tibble (desired formatting):

image

@alexhallam
Copy link
Owner

alexhallam commented Jul 22, 2022

Great point @briandconnelly. Tibble output is what I am going for.

I believe I am right aligning, but I left a large space because I was assuming people would pass large csvs though tv.

Now that I type this I can't believe I did not consider using the row count to inform the spacing.

I just need to make sure the row count is conditioned on rows passed via the row count flag.

@alexhallam alexhallam added the enhancement New feature or request label Jul 22, 2022
@alexhallam
Copy link
Owner

alexhallam commented Jul 23, 2022

I see what you are saying now. As you stated, the row numbers need to be right aligned.

@alexhallam
Copy link
Owner

How does this look? #143

image

@alexhallam
Copy link
Owner

I think I am going to add one more space between the row index and the table. It feels a little cramped.

@alexhallam
Copy link
Owner

@briandconnelly What do you think of this?

image

@alexhallam
Copy link
Owner

We got the right alignment correct now. Just let me know if you prefer one or two spaces between the row index and the first column.

@briandconnelly
Copy link
Author

Looks great!! Thank you for the quick response and a great tool!

@alexhallam
Copy link
Owner

you can now get the functionality in version 1.4.6

@lulunac27a
Copy link

@briandconnelly What do you think of this?

image

Some columns (carat, depth, table, price, x, y, z) that are only numbers with table and price columns are integers (numeric values without a dot/decimal point) should be right-aligned by default.

@alexhallam
Copy link
Owner

Looks nice

@briandconnelly
Copy link
Author

Agree, this looks great!

@alexhallam alexhallam reopened this Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants